You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Theming: compute the primary color based on the background image #34560
I guess the difference is if we want an "accent" colour or more like an "average" colour.
I would go for Vibrant (personal preference), otherwise Muted seems to be good ? 🤷
My vote would be for DarkVibrant. With Muted my worry is that
there might not be enough contrast between text and bg
it seems more like an "average" color of all the colors in the picture, so there's less of a direct association between the color and the picture
I also like Vibrant, but in some of the pictures (like the one with the cat) it doesn't seem like a prominent color at all, but it is chosen as primary simply because it "pops" the most.
Another possible idea for the future: in the color picker for theming your account, show this list of colors as "Suggested colors based on your background" in addition to the default colors.
Another possible idea for the future: in the color picker for theming your account, show this list of colors as "Suggested colors based on your background" in addition to the default colors.
@skjnldsv I think for the shipped backgrounds we should continue to use the preset colors we currently have. We generated them by using the Material Design customizer, and that works pretty well (might even be the best algorithm).
The color generator with DarkVibrant of course we use for individual uploaded backgrounds. :)
Maybe this is not the right place to discuss this, feel free to point me somewhere else.
I can see how it's a nice feature to ship an accent color for the predefined background images, but when I upgraded to 25, I really felt like this was a bug.
I had selected one of the default images (the big wheel) in a previous version and suddenly my accent color went from the one that I had set globally in the theming settings to a somewhat ugly brown (I know, that's subjective 😉)
I thought, well, it's a nice feature, but I can probably change that – however, I can't seem to do that. Whenever I select this image as my background, it automatically sets the brown. Maybe I'm missing something?
It feels like a regression that we don't allow users to select their accent color separately from the background image, if we're already doing introducing so many layers to the color/background settings... 🤓
Activity
PVince81 commentedon Oct 12, 2022
currently as an alternative we will let the user pick the primary color themselves: #34437
skjnldsv commentedon Oct 13, 2022
This require an extra step:
Then we can address this.
jancborchardt commentedon Oct 20, 2022
skjnldsv commentedon Oct 20, 2022
skjnldsv commentedon Oct 20, 2022
@jancborchardt @nimishavijay I'm gonna use this library https://jariz.github.io/vibrant.js/
It generate a few type of colour from an image, please tell me which of the following I should use as primary:
skjnldsv commentedon Oct 20, 2022
I guess the difference is if we want an "accent" colour or more like an "average" colour.
I would go for Vibrant (personal preference), otherwise Muted seems to be good ? 🤷
nimishavijay commentedon Oct 20, 2022
My vote would be for DarkVibrant. With Muted my worry is that
I also like Vibrant, but in some of the pictures (like the one with the cat) it doesn't seem like a prominent color at all, but it is chosen as primary simply because it "pops" the most.
Another possible idea for the future: in the color picker for theming your account, show this list of colors as "Suggested colors based on your background" in addition to the default colors.
cc @jancborchardt
skjnldsv commentedon Oct 20, 2022
I could do that later yep :)
Would need nextcloud-libraries/nextcloud-vue#3384
jancborchardt commentedon Oct 20, 2022
Yeah, I'm also unsure between Vibrant and DarkVibrant. The others I would for sure exclude.
Vibrant seems great but not accessible as @nimishavijay said, so let's indeed go with DarkVibrant?
2 remaining items
skjnldsv commentedon Oct 21, 2022
Thank you both :)
PVince81 commentedon Oct 25, 2022
WIP PR here: #34696
PVince81 commentedon Oct 25, 2022
~1 week of work to get it done but too risky and too involved for 25, so 26 then
PVince81 commentedon Oct 25, 2022
to clarify: 25.0.1 will already have manual selection of primary color so the base requirement was already there
so no feature regression
and this automatic detection is "nice to have"
skjnldsv commentedon Nov 23, 2022
@jancborchardt @nimishavijay since we're taking
DarkVibrant, the shipped background doesn't use the proper colours. Do you want to adjust them for 26 ?I made a quick tool to see what it would look like with
DarkVibranton our shipped backgroundshttps://codesandbox.io/embed/vibrant-test-nextcloud-vrudvv?view=preview
jancborchardt commentedon Nov 28, 2022
@skjnldsv I think for the shipped backgrounds we should continue to use the preset colors we currently have. We generated them by using the Material Design customizer, and that works pretty well (might even be the best algorithm).
The color generator with DarkVibrant of course we use for individual uploaded backgrounds. :)
skjnldsv commentedon Nov 28, 2022
Good from me! 👍
Feel free to test and review #34696 then 😉
te-online commentedon Apr 22, 2023
Maybe this is not the right place to discuss this, feel free to point me somewhere else.
I can see how it's a nice feature to ship an accent color for the predefined background images, but when I upgraded to 25, I really felt like this was a bug.
I had selected one of the default images (the big wheel) in a previous version and suddenly my accent color went from the one that I had set globally in the theming settings to a somewhat ugly brown (I know, that's subjective 😉)
I thought, well, it's a nice feature, but I can probably change that – however, I can't seem to do that. Whenever I select this image as my background, it automatically sets the brown. Maybe I'm missing something?
It feels like a regression that we don't allow users to select their accent color separately from the background image, if we're already doing introducing so many layers to the color/background settings... 🤓