Repository navigation
Enable usage of svg favicons and remove imagick from iconbuilder #36607
Description
This allows us to get rid of using imagick in iconbuilder of the theming app, which in return allows us to not enforce this requirement anymore since gd and imaginary can be used for all other tasks.
Julius found this: https://www.leereamsnyder.com/blog/favicons-in-2021#safari-does-not-fully-support-svg-icons
Activity
szaimen commentedon Feb 8, 2023
also cc @nextcloud/ios
juliusknorr commentedon Feb 8, 2023
Seems to work just fine with an svg and the mask for safari:
Now we'd need to check if there is a way to invert the svg to be filled with masking out the app icon or if the new safari icon design would be fine, but otherwise I'd say it would be a good step to get rid of imagick there.
juliusknorr commentedon Feb 8, 2023
Would also solve #27502
szaimen commentedon Feb 8, 2023
Great 🎉
[-]investigate if safari now supports svg favicons [/-][+]Enabke usage of svg favicons and remove imagick from iconbuilder[/+][-]Enabke usage of svg favicons and remove imagick from iconbuilder[/-][+]Enable usage of svg favicons and remove imagick from iconbuilder[/+]szaimen commentedon Feb 8, 2023
Maybe someone with a mac could look into this for 27? :)
I could help testing a PR on other platforms :)
szaimen commentedon Mar 7, 2023
Also cc @AndyScherzinger
AndyScherzinger commentedon Mar 7, 2023
I am not having a mac, so If it works for Julius I think we are fine.
szaimen commentedon May 1, 2023
Also cc @nextcloud/server
solracsf commentedon Sep 27, 2023
Any chances to see this landing in v28?
szaimen commentedon Sep 27, 2023
It was not prioritized so unfortunately no. But cc @sorbaugh and @AndyScherzinger
AndyScherzinger commentedon Sep 27, 2023
What @szaimen said. So given our priorities for v28 we won't have the capacity. However if somebody would be willing to contribute an implementation than we are more than happy to review'n'merge it.
feat(theming): generate favicons and touch icons as SVG without imagick
szaimen commentedon Sep 23, 2026
WIP in #64703
feat(theming): generate favicons as SVG without imagick
feat(theming): generate favicons as SVG without imagick