Repository navigation
Remove nearly unused jquery-ui #4134
Description
I tested by removing the jQuery-UI code (and our fixes) and the only thing I noticed that is only the autocomplete bar, that is not properly styled. We should maybe look into this, because we updated this library the last time nearly 3 years ago and don't use it anymore that often. Our dialog windows use something different, the LDAP assistant still works and the calendar also looks fine.
@nickvergessen @jancborchardt @rullzer Do you want to look into get rid of those unneeded 500 kB that are loaded on every page? (that's more than 25% of all bytes we transfer for an uncached page load on files)
Activity
rullzer commentedon Mar 29, 2017
I'm all for it. our javascript libs are way to outdated so getting rid of some is an even better approach.
Also loading ~500kb is just bs for such a small thing.
I don't know enough about styling to fix it tough...
jancborchardt commentedon Mar 29, 2017
Yes please. Most of the autocomplete bar I styled over for Nextcloud 11 or already 10 anyway. :)
Can you prepare a pull request so we can see what exactly happens, and adjust the issues?
Great initiative!
MorrisJobke commentedon Mar 29, 2017
Damn - caching got me -.- After properly removing it, many things fell apart. I guess we need to do this in steps. Like the search relies on this somehow and the LDAP assistant as well. :/ So it doesn't seem to be that easy. Nevertheless - I want to get rid of this monster, because it's a huge pile of not upgradable code.
MorrisJobke commentedon Mar 29, 2017
There are just too much cross dependencies. It's just untameable :/ I guess we need to live with if for now 😢
jancborchardt commentedon Mar 29, 2017
Let’s keep this open though and just do it step by step? It’s technical debt after all.
MorrisJobke commentedon Mar 29, 2017
I tried some step by step, but we use it sadly at many places. From the LDAP accordion effect, to the autocomplete over to drag and drop behaviour of the files app. :/
pixelipo commentedon Dec 18, 2017
timepicker and datepicker also use jquery-ui
jancborchardt commentedon Jan 5, 2018
True, and otherwise we would need to reimplement these things.
While we should not overuse it, the existing use is valid. Closing hence.