Repository navigation
Topbar icons and text are controlled by wrong variable #42954
Description
How to use GitHub
- Please use the 👍 reaction to show that you are interested into the same feature.
- Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
- Subscribe to receive notifications on status change and new comments.
Steps
- Use default background image
- Change theming color to the yellow option
| Default blue | Option yellow |
|---|---|
| ✅ | 💥 Text and all icons on the right side have the wrong color (based on primary and not if background is bright/dark, but that fact is used by the app icons in top left with var(--background-image-invert-if-bright) vs. var(--color-primary-text) |
 |
 |
| Default blue | Option yellow |
|---|---|
| 💥 "More apps" icon has wrong color | 💥 "More apps" icon has wrong color |
 |
 |
Activity
JuliaKirschenheuter commentedon Jan 19, 2024
cc @szaimen
JuliaKirschenheuter commentedon Jan 19, 2024
probably #42620 is a problem
SystemKeeper commentedon Jan 19, 2024
nickvergessen commentedon Jan 19, 2024
szaimen commentedon Jan 19, 2024
szaimen commentedon Jan 19, 2024
No, the fix works correctly for the default themes which are more important then custom primary colors imho.
In order to fix all the cases correclty, we would need to have another UI setting that allows to set the color (black or white) for the header icons independently and not calculate it from any other value. See #35482 (comment)
susnux commentedon Jan 19, 2024
I think to make the color background image dependent it would work to use:
Again this will not cover all cases especially for background images with shapes in different color.
szaimen commentedon Jan 19, 2024
yes, that is why I pointed at #35482 (comment)
11 remaining items
nursoda commentedon Feb 15, 2024
Since milestone 28.0.2 is mentioned above: It's not fixed in 28.0.2 – counting on 28.0.3 – it's NOT fixed in 28.0.3 RC1.
nursoda commentedon Feb 15, 2024
susnux commentedon Feb 15, 2024
@nursoda this is unrelated - happens because of the icon SVG of the dashboard app.
nursoda commentedon Feb 15, 2024
ObiWahn commentedon Feb 17, 2024
please fix this, I have to deal with a lot of non technical users and they seem to care much more about this than about any other functional bug.
escoand commentedon Feb 17, 2024
Duplicate of #43298
susnux commentedon Feb 17, 2024
No this one is a different issue, this one is about the wrong color of the app bar icons when you select a different primary color.
In the example using the default clouds background image + yellow primary color will set black text of the app menu entries -> wrong color for the background image.
susnux commentedon Feb 17, 2024
@ObiWahn looks fine on the screenshot, but you have set up a too bright background color which then causes the text color to switch to black.
The text color will always try to be at least 4.5:1 color contrast to the background color. This is needed for accessibility.
Try to set the background color to
#00679ewhich is the default, this will then use white text and icons on the app navigation.ObiWahn commentedon Feb 18, 2024
Thanks @susnux, everything should be stock, I do not even know how to modify the themes.
After some testing:
index.php/settings/user/themingQuestion:
susnux commentedon Feb 18, 2024
https://docs.nextcloud.com/server/latest/admin_manual/configuration_server/theming.html#theming
Yes we needed to adjust the colors for accessibility and it seems we need to adjust the color picker defaults.
Once #42977 is merged this will be finally fixed.