Skip to content

Kill \OC_App::installApp #4453

Closed
#4867
Closed
Kill \OC_App::installApp#4453
#4867
Labels
3. to reviewWaiting for reviewsbug
Milestone
Nextcloud 12.0

Description

@LukasReschke
LukasReschke
opened on Apr 23, 2017

\OC_App::installApp is a duplicate of \OC\Installer::installApp which wouldn't be a problem if the code however wouldn't be different…

So the OC_App method is for example setting up the settings sidebar while the OC\Installer one is not. The OC_App one should simply invoke the \OC\Installer.

Activity

  1. LukasReschke
    added
    bug
    on Apr 23, 2017
  2. LukasReschke
    added this to the Nextcloud 12.0 milestone on Apr 23, 2017
  3. MorrisJobke
    added a commit that references this issue on May 15, 2017

    Remove OC_App:installApp

    be33234
  4. MorrisJobke
    added
    3. to reviewWaiting for reviews
    on May 15, 2017

  5. MorrisJobke commented on May 15, 2017

    @MorrisJobke
    MorrisJobke
    on May 15, 2017
    Member

    Fix is in #4867

  6. LukasReschke
    closed this as completedin #4867on May 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    3. to reviewWaiting for reviewsbug

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions