Skip to content

JS tests failing on CI #4487

Description

@LukasReschke

Activity

  1. added this to the Nextcloud 12.0 milestone on Apr 25, 2017
  2. changed the title [-]JS tests failing on cI[/-] [+]JS tests failing on CI[/+] on Apr 25, 2017
  3. LukasReschke commented on Apr 25, 2017

    @LukasReschke
    MemberAuthor

    Let's just migrate away from the PhantomJS launcher and switch to headless Chrome instead: karma-runner/karma-chrome-launcher#111

  4. ChristophWurst commented on Apr 25, 2017

    @ChristophWurst
    Member

    Ouch. This is bad. Headless Chrome doesn't qualify for a short-term solution as that PR has not been merged.

  5. ChristophWurst commented on Apr 25, 2017

    @ChristophWurst
    Member

    cc @nextcloud/javascript

  6. LukasReschke commented on Apr 25, 2017

    @LukasReschke
    MemberAuthor

    @MorrisJobke mentioned that pinning Karma 1.5.x might make sense as a temporary workaround.

  7. MorrisJobke commented on Apr 25, 2017

    @MorrisJobke
    Member

    I thought it is because the dependencies has changed, so I looked it up and this is the diff between working and not working:

    bildschirmfoto 2017-04-25 um 10 19 04

    That means we should check if pinning jasmine-core helps.

  8. MorrisJobke commented on Apr 25, 2017

    @MorrisJobke
    Member

    "Fix" is in #4494

    Nevertheless we should migrate to the other launcher if this is the only option. 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions