Skip to content

Starring a "Recent" file triggers a download instead #4568

Description

@le-fractal

Steps to reproduce

  1. In the Files app, open the "Recent" files list from the left menu
  2. Open the "Details" panel for any file
  3. Click the star to add the file to your favorite

Expected behaviour

The file should be favorited.

Actual behaviour

The file is not favorited and the browser is prompted to download the file.

Server configuration

Operating system: Debian 8 "Jessie"

Nextcloud version: 11.0.3

Updated from an older Nextcloud/ownCloud or fresh install: update from 11.0.2

Where did you install Nextcloud from: zip file from nextcloud.com

Enabled apps

  • activity: 2.4.1
  • calendar: 1.5.2
  • comments: 1.1.0
  • contacts: 1.5.3
  • dav: 1.1.1
  • federatedfilesharing: 1.1.1
  • files: 1.6.1
  • files_markdown: 1.0.1
  • files_pdfviewer: 1.0.1
  • files_sharing: 1.1.1
  • files_texteditor: 2.2
  • files_trashbin: 1.1.0
  • files_versions: 1.4.0
  • gallery: 16.0.0
  • logreader: 2.0.0
  • lookup_server_connector: 1.0.0
  • notes: 2.2.0
  • notifications: 1.0.1
  • provisioning_api: 1.1.0
  • serverinfo: 1.1.1
  • sharebymail: 1.0.1
  • systemtags: 1.1.3
  • tasks: 0.9.5
  • templateeditor: 0.2
  • theming: 1.1.1
  • twofactor_backupcodes: 1.0.0
  • updatenotification: 1.1.1
  • workflowengine: 1.1.1

Client configuration

Browser: Firefox 52.0.1

Operating system: Open Suse Leap 42.2

Activity

  1. MorrisJobke commented on Apr 29, 2017

    @MorrisJobke
    Member
  2. added
    papercutAnnoying recurring UX issue with possibly simple fix.
    on May 10, 2017
  3. added this to the Nextcloud 13 milestone on Jul 3, 2017
  4. MorrisJobke commented on Nov 14, 2017

    @MorrisJobke
    Member

    cc @nextcloud/javascript

  5. danxuliu commented on Jan 4, 2018

    @danxuliu
    Member

    This happens on current master too.

    The problem is that the Favorite file action is added only to some of the file lists, but the icon in the details view is shown unconditionally for every file list, so when it is clicked and the Favorite action is tried to be triggered it is not found and the Download action is executed instead.

    This could be fixed by showing the icon in the details view only when there is a Favorite file action available.

    Another option would be to add the Favorite action to every file list, although the conditional rendering of the icon should be added anyway to make the behaviour more robust.

  6. MorrisJobke commented on Jan 8, 2018

    @MorrisJobke
    Member

    Fixed by #7716

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    1. to developAccepted and waiting to be taken care ofbugfeature: filespapercutAnnoying recurring UX issue with possibly simple fix.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions