Show reason why group restriction not possible for that app

@eppfel

Papercut from #2672

cc @eppfel @MariusBluem because you always asked for this

@MorrisJobke

@MorrisJobke Is this still of interest or can it be closed? Can't there be several reasons - none of them giving the reader any practical benefit?

Can't there be several reasons - none of them giving the reader any practical benefit?

Yes there can be different and it would be helpful to communicate why given features are not there IMO.

I suppose these are the reasons:

server/apps/settings/src/mixins/AppManagement.js

Lines 74 to 82 in 7ddad46

    
           canLimitToGroups(app) { 
        
           	if ((app.types && app.types.includes('filesystem')) 
        
           			|| app.types.includes('prelogin') 
        
           			|| app.types.includes('authentication') 
        
           			|| app.types.includes('logging') 
        
           			|| app.types.includes('prevent_group_restriction')) { 
        
           		return false 
        
           	} 
        
           	return true

server/apps/settings/src/components/AppStoreSidebar/AppDetailsTab.vue

Line 15 in 7ddad46

    
           <div v-if="app.active && canLimitToGroups(app)" class="app-details__actions-groups">

server/lib/private/App/AppManager.php

Lines 35 to 44 in 7ddad46

    
           	 * Apps with these types can not be enabled for certain groups only 
        
           	 * @var string[] 
        
           	 */ 
        
           	protected $protectedAppTypes = [ 
        
           		'filesystem', 
        
           		'prelogin', 
        
           		'authentication', 
        
           		'logging', 
        
           		'prevent_group_restriction', 
        
           	];

Apps this applies to:

https://github.com/search?q=org%3Anextcloud+path%3A%2F%28%5E%7C%5C%2F%29info%5C.xml%24%2F+filesystem+OR+prelogin+OR+authentication+OR+logging+OR+prevent_group_restrictions&type=code

For many (most?) of these it's somewhat obvious why they can't be limited. But I can see how a few might be surprising (e.g. Collectives, Photos, Maps, Community Document Server, Office Online, Activity).

Navigation Menu

Repository navigation

Show reason why group restriction not possible for that app #4864

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	canLimitToGroups(app) {
	if ((app.types && app.types.includes('filesystem'))
	\|\| app.types.includes('prelogin')
	\|\| app.types.includes('authentication')
	\|\| app.types.includes('logging')
	\|\| app.types.includes('prevent_group_restriction')) {
	return false
	}
	return true

	* Apps with these types can not be enabled for certain groups only
	* @var string[]
	*/
	protected $protectedAppTypes = [
	'filesystem',
	'prelogin',
	'authentication',
	'logging',
	'prevent_group_restriction',
	];

Show reason why group restriction not possible for that app #4864

Description

Activity

wiswedel commented on May 27, 2019

MorrisJobke commented on May 27, 2019

szaimen commented on May 21, 2021

joshtrichards commented on Sep 23, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions