"Unspecified share exception" instead of proper 404 page on unknown public share tokens

@nickvergessen

open a public share page with a not available share token - like http://example.org/s/abcdef
expected: get a proper 404 page
actual: get a "Unspecified share exception"

Ideas when this came in?

@nextcloud/sharing @nickvergessen

@oparoz

cc @oparoz

Yeah

server/lib/private/Share20/DefaultShareProvider.php

Lines 809 to 815 in f707a40

    
           	throw new ShareNotFound(); 
        
           } 
        
           try { 
        
           	$share = $this->createShare($data); 
        
           } catch (InvalidShare $e) { 
        
           	throw new ShareNotFound();

would need some dedicated message. Not sure why this was not done, but I guess there is no reason?

Navigation Menu

Repository navigation

"Unspecified share exception" instead of proper 404 page on unknown public share tokens #5346

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	throw new ShareNotFound();
	}

	try {
	$share = $this->createShare($data);
	} catch (InvalidShare $e) {
	throw new ShareNotFound();

"Unspecified share exception" instead of proper 404 page on unknown public share tokens #5346

Description

Activity

MorrisJobke commented on Jun 12, 2017

nickvergessen commented on Jun 13, 2017

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions