Skip to content

Show checkbox where the favorite star is now #6361

Closed

Description

@MorrisJobke

As discussed at the conf:

  • show the checkbox for selecting an element where currently the star icon is
  • add a little star indicator at the top right of the mime type/thumbnail (as on Android and iOS)
  • add the "Favourite" action to the three dots menu

cc @nextcloud/designers

@danxuliu @ChristophWurst Does one of you want to look into this?

Activity

  1. added this to the Nextcloud 13 milestone on Sep 4, 2017
  2. self-assigned this
    on Sep 11, 2017
  3. danxuliu commented on Sep 11, 2017

    @danxuliu
    Member

    I will take care of this in the next days.

  4. jancborchardt commented on Sep 17, 2017

    @jancborchardt
    Member

    An important addition is that the filetype icon / preview should then also be part of the clickable area to open the file / folder.

    @danxuliu let me know when there’s something to review. :)

  5. changed the title [-]Show checkbox where the favourite star is now[/-] [+]Show checkbox where the favorite star is now[/+] on Sep 22, 2017
  6. danxuliu commented on Sep 22, 2017

    @danxuliu
    Member

    @jancborchardt I have started to implement this but as you can imagine there are several approaches for the CSS that would work. So any preference with respect to floats, absolute positions and things like that? Although probably someone else with good CSS knowledge will have to clean up my mess anyway :-P

    An important addition is that the filetype icon / preview should then also be part of the clickable area to open the file / folder.

    I assume that the star indicator would not be clickable given that the Favourite action will be now in the three dots menu, right? Otherwise making the star indicator clickable and at the same time using the filetype icon / preview to open the file / folder would be very error prone.

  7. skjnldsv commented on Sep 23, 2017

    @skjnldsv
    Member

    @danxuliu, I will help with css. Do everything you can. I will take a look at it! 👍 😉

  8. danxuliu commented on Sep 24, 2017

    @danxuliu
    Member

    I will help with css. Do everything you can. I will take a look at it! 👍 😉

    Thanks a lot! :-) I will ping you in the next days ;-)

  9. jancborchardt commented on Sep 25, 2017

    @jancborchardt
    Member

    I assume that the star indicator would not be clickable given that the Favourite action will be now in the three dots menu, right?

    Exactly, the favorite star would only be an indicator, not clickable. :)

  10. self-assigned this
    on Sep 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions