Skip to content

(Group) shares should list all users that received the share #6480

Closed

Description

@MorrisJobke
  • having a group with user A, B, C, D
  • user A shares with this group a folder
  • user B now only sees, that it is shared with that group, but does not know who is in this group and therefore maybe reshares to user C

Related to #3392, #4281 and how shares in circles are handled.

cc @nextcloud/designers for nice ideas how to show this
cc @daita for circles
cc @nextcloud/sharing for the general sharing stuff

Activity

  1. ArtificialOwl commented on Sep 13, 2017

    @ArtificialOwl
    Member

    I don't know if we should display the memberlist, but maybe (if it is not already the case) check if the file is already shared in any way (circles, groups, ...) to C (and display a message that the file is already shared). Like browsing all provider->getSharedWith() (not sure at 100% on this call).

    Now, what is gonna happen if A share a folder to the group and B shares a single file from this folder to C ?

  2. rullzer commented on Sep 13, 2017

    @rullzer
    Member

    Listing all members is a big no go. This will explode hard. Assume an LDAP group with 10k members. That is not going to be of any use.

    What we should do (what is still on the TODO somewhere) is do more grouping of shares. So that the receiving end doesn't care.

    Then we can also lift this silly restrictiong that you can't share to somebody that already got the share. Since it will be grouped anyway.

  3. jancborchardt commented on Sep 13, 2017

    @jancborchardt
    Member

    Besides @rullzer’s point what we could do is show a tooltip with the members, or at least the first 10 »and 25 more«. That’s similar to how Github does it for teams when you hover them (see above in @MorrisJobke’s original issue when you hover the designers group) and also how we did it in the video calls app navigation.

  4. changed the title [-]Group shares should list all members that received the share[/-] [+](Group) shares should list all members that received the share[/+] on Jul 24, 2018
  5. changed the title [-](Group) shares should list all members that received the share[/-] [+](Group) shares should list all users that received the share[/+] on Jul 24, 2018
  6. ghost removed
    staleTicket or PR with no recent activity
    on Jun 12, 2019
  7. skjnldsv commented on Jan 28, 2020

    @skjnldsv
    Member

    I guess fixed with 18 righty?
    With the new inherited shares :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    1. to developAccepted and waiting to be taken care ofdesignDesign, UI, UX, etc.enhancementfeature: sharingpapercutAnnoying recurring UX issue with possibly simple fix.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions