Skip to content

Dev work inside apps is overwritten by marketplace app version聽#7011

Closed

Description

@jancborchardt

As @Henni wrote in nextcloud/contacts#305 (comment)

I lost my work when my dev instance overwrote my git repository during an update... 馃槩

This shouldn鈥檛 happen.

@ChristophWurst suggested:

It's simple: if an app is downgraded, then don't replace it. Alternatively, don't run the update everything that can be updated after an app update/downgrade.

I added:

or is it possible to check if the app is checked out via git? In that case it should of course not be upgraded with one from the app store.

Activity

  1. added this to the Nextcloud 13 milestone on Oct 30, 2017
  2. jancborchardt commented on Oct 30, 2017

    @jancborchardt
    MemberAuthor
  3. MorrisJobke commented on Oct 30, 2017

    @MorrisJobke
    Member

    or is it possible to check if the app is checked out via git?

    Not that easy, because you never know where the .git folder for example is placed.

    Maybe we should disable app store updates if the update channel is git? On the other side: testing this feature and finding bugs in it is also quite hard. :/

  4. jancborchardt commented on Oct 30, 2017

    @jancborchardt
    MemberAuthor

    Not that easy, because you never know where the .git folder for example is placed.

    For the main apps though it鈥檚 directly in the root folder of the app, no?

    What do you think about @ChristophWurst鈥檚 solution?

  5. MorrisJobke commented on Oct 30, 2017

    @MorrisJobke
    Member

    For the main apps though it鈥檚 directly in the root folder of the app, no?

    Sure, but what about for example the social sharing apps it is in a parent folder. And getting all this in our code feels cumbersome.

    It's simple: if an app is downgraded, then don't replace it. Alternatively, don't run the update everything that can be updated after an app update/downgrade.

    Sometimes it's also an upgrade, because you forgot to pull and a new release is already in the app store 馃槈

    But yes - downgrades should not be done, because this really does not make sense and also would brick that app.

  6. added a commit that references this issue on Nov 6, 2017
  7. jancborchardt commented on Nov 11, 2017

    @jancborchardt
    MemberAuthor

    So do we have a dead-simple first solution for 13?

    Would be good if app devs like @Henni and @ChristophWurst don't randomly lose their work because of a core issue. ;)

  8. MorrisJobke commented on Dec 14, 2017

    @MorrisJobke
    Member

    Fix is in #7505

  9. skjnldsv commented on Dec 14, 2017

    @skjnldsv
    Member

    Fix is in #7505

    Nice, I forgot there was an issue about this! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions