Repository navigation
audio-white and audio-off-white lost their shadows聽#7243
Description
Activity
cc @pixelipo for the breaking PR
I'm on it
Ok, here's the status report:
While cleaning up icons, I kept their SVG-based shadows so as not to make too huge PR. Plan was (and still is) to move shadows to CSS.
Somehow I accidentally removed shadows from these two icons (video icon still has it...)So, no that the damage is done, I can go ahead and implement the CSS shadow to this icon, but I need some input from @nextcloud/designers
Using the "default" drop-shadow filter introduced by @jancborchardt recently (filter: drop-shadow(0 1px 3px $color-box-shadow);), we get this kind of result:
Compare that to the unmodified video icon - it's clearly not as visible. But is that OK? Should I make a more prominent shadow for this use-case?Second problem: IMO shadow is clearly something that should not be part of an icon itself, because it can be displayed on a dark background in which case it shouldn't have a shadow. So, should I create a new class
.icon-shadedfor shadows or only add it to specific cases, like.videoContainer .icon-audio-white?IMO shadow is clearly something that should not be part of an icon itself
Seconded
I'd say simplest solution is to revert to the icon version with shadow, especially as the video icon still has it, and we are well past feature freeze for any CSS experimentation.
And imo the shadow-on-dark-background thing is not really an issue, no? As then we need code to always check the background (which can change a lot in the Talk app), whereas simply always having the shadow doesn't do any bad on a dark background as you simply don't see the shadow there.
We already use filter drop shadow, so I don't think this is an experimentation :)
@jancborchardt I think it is an issue - say you want to add those icons to the header:
If it is OK for white icons to always have shadows, then we should add the shadow to all of them...
@pixelipo ok good point :) go for it then.
Thanks @jancborchardt , but I'm afraid I need few more pointers :)
- is
filter: drop-shadow(0 1px 3px $color-box-shadow);strong enough shadow for this use-case (see my first screenshot)? - should I only add shadow to specific use-case:
.videoContainer .icon-audio-white { }?
OR - should I add shadow globally to this icon:
.icon-audio-white { }?
- is
I'd go with a
icon-shadowI thinkReacted by Marin Treselj, John Molakvo忙 and Jan C. Borchardt- Yeah I'd say it's good. We can always adjust.
- Yep, for now only in this case. There's only a few cases where icons need shadow, like a) Gallery detail view b) sidebar preview image for x button c) video calls app any icon over video d) future grid view for icons on a preview.
(And yes, agree it's probably best to do it by using .icon-shadow :)
Regression from #7130
This "breaks" the spreed/talk app, because the mute button is not visible anymore when your video is off:
@jancborchardt @pixelipo can you please fix before 13
@MorrisJobke "blocker" please 馃槩