Repository navigation
Small adjustments needed to the login screen #7265
Description
Copied from #7249 (comment)
OK, here's my review opinion. I'm adding it as a comment since it's not breaking issues, but I would like to see these fixed:
-
Logo is too high up; actually, its distance from top is OK, but now it's too far from the
formitself:
I would remove 16px top+bottom margins fromform {}in guest.css since they don't seem needed -
Is there a reason why
footerhasheight: 70px? We can easily remove it (I think) and change thep.info {margin: 0 auto; padding-top: 20px;to simplerp.info {margin: 20px auto;}Added advantage to these changes would mean that the whole page would fit nicely on 320*480 screen:
-
"Wrong password " warning is above the
#submit# button, but the#lost-password` warning is bellow - makes no sense at all:
-
Additionally, "Lost Password" warning also has
opacity: .7;added to it for some reason.
Activity
rpirritano commentedon Nov 29, 2017
@pixelipo Is this still available? If so I can take it?
pixelipo commentedon Nov 30, 2017
Yes it is, @rpirritano - be my guest :)
rpirritano commentedon Dec 16, 2017
@pixelipo ,
For item #3 above, do you want the Wrong Password warning to no longer appear on that page or do you just want it to remain, but right above lost-password warning?
pixelipo commentedon Dec 16, 2017
Ot should definitely appear under all the buttons. Ideally, it should also disappear as soon as "Forgot password?" button is clicked. That way, only one error should be visible at any given moment.
rpirritano commentedon Dec 29, 2017
I completed all the above changes, submitted the pull request.
juliusknorr commentedon Jul 2, 2018
Fixed with #7650