SMB/CIFS share breaks when it contains a single entry that can't be accessed #7332

Activity

1. MorrisJobke

   added

   bug

   feature: external storage

   on Dec 14, 2017
2. MorrisJobke commented on Dec 14, 2017

   

   MorrisJobke

   on Dec 14, 2017

   Member

   More actions

   cc @icewind1991
3. icewind1991 commented on Dec 18, 2017

   

   icewind1991

   on Dec 18, 2017

   Member

   More actions

   @segdy can you see if #7556 fixes the problem for you
4. MorrisJobke commented on Dec 18, 2017

   

   MorrisJobke

   on Dec 18, 2017

   Member

   More actions

   Fixed with #7556
5. MorrisJobke

   closed this as completedon Dec 18, 2017
6. eigenphase commented on Dec 24, 2017

   

   eigenphase

   on Dec 24, 2017

   Author

   More actions

   Great - seems to work!
7. rik26 commented on Jun 4, 2019

   

   rik26

   on Jun 4, 2019

   Last edited by rik26

   More actions

   Hi,

   I still have the problem with Nextcloud 16 :
   My samba server is configured not to follow symbolic links.

   If create a symlink on a share, the share content listing fails through WEB UI (sorry for my english)
   With smbclient, cd to the symlink gives "NT_STATUS_ACCESS_DENIED".

   I reviewed the file apps/files_external/lib/Lib/Storage/SMB.php and it seems the patch is already in place.

   The try catch code shoud do the trick but it does not....

   Cheers.

   log 👍{"reqId":"h9bFanEGQj9WuklaRLsJ","level":1,"time":"2019-06-05T09:41:45+00:00","remoteAddr":"172.30.2.2","user":"laurentq","app":"no app in context","method":"GET","url":"/index.php/apps/files_external/userglobalstorages/6?testOnly=false","message":"External storage not available: Invalid request for /Public (ForbiddenException)","userAgent":"Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:67.0) Gecko/20100101 Firefox/67.0","version":"16.0.1.1"}
   {"reqId":"h9bFanEGQj9WuklaRLsJ","level":0,"time":"2019-06-05T09:41:45+00:00","remoteAddr":"172.30.2.2","user":"laurentq","app":"no app in context","method":"GET","url":"/index.php/apps/files_external/userglobalstorages/6?testOnly=false","message":{"Exception":"Icewind\SMB\Exception\ForbiddenException","Message":"Invalid request for /Public (ForbiddenException)","Code":13,"Trace":[{"file":"/var/www/nextcloud/apps/files_external/3rdparty/icewind/smb/src/Native/NativeState.php","line":62,"function":"fromMap","class":"Icewind\SMB\Exception\Exception","type":"::","args":[{"1":"Icewind\SMB\Exception\ForbiddenException","2":"Icewind\SMB\Exception\NotFoundException","13":"Icewind\SMB\Exception\ForbiddenException","16":"Icewind\SMB\Exception\FileInUseException","17":"Icewind\SMB\Exception\AlreadyExistsException","20":"Icewind\SMB\Exception\InvalidTypeException","21":"Icewind\SMB\Exception\InvalidTypeException","22":"Icewind\SMB\Exception\InvalidArgumentException","28":"Icewind\SMB\Exception\OutOfSpaceException","39":"Icewind\SMB\Exception\NotEmptyException","110":"Icewind\SMB\Exception\TimedOutException","111":"Icewind\SMB\Exception\ConnectionRefusedException","112":"Icewind\SMB\Exception\HostDownException","113":"Icewind\SMB\Exception\NoRouteToHostException"},13,"/Public"]},{"file":"/var/www/nextcloud/apps/files_external/3rdparty/icewind/smb/src/Native/NativeState.php","line":74,"function":"handleError","class":"Icewind\SMB\Native\NativeState","type":"->","args":["/Public"]},{"file":"/var/www/nextcloud/apps/files_external/3rdparty/icewind/smb/src/Native/NativeState.php","line":184,"function":"testResult","class":"Icewind\SMB\Native\NativeState","type":"->","args":["*** sensitive parameter replaced ","smb://172.30.1.20/laurentq/Public"]},{"file":"/var/www/nextcloud/apps/files_external/3rdparty/icewind/smb/src/Native/NativeShare.php","line":133,"function":"stat","class":"Icewind\SMB\Native\NativeState","type":"->","args":["smb://172.30.1.20/laurentq/Public"]},{"file":"/var/www/nextcloud/apps/files_external/3rdparty/icewind/smb/src/Native/NativeShare.php","line":98,"function":"getStat","class":"Icewind\SMB\Native\NativeShare","type":"->","args":["//Public"]},{"function":"Icewind\SMB\Native\{closure}","class":"Icewind\SMB\Native\NativeShare","type":"->","args":[" sensitive parameters replaced "]},{"file":"/var/www/nextcloud/apps/files_external/3rdparty/icewind/smb/src/Native/NativeFileInfo.php","line":82,"function":"call_user_func","args":[{"class":"Closure"}]},{"file":"/var/www/nextcloud/apps/files_external/3rdparty/icewind/smb/src/Native/NativeFileInfo.php","line":99,"function":"stat","class":"Icewind\SMB\Native\NativeFileInfo","type":"->","args":[]},{"file":"/var/www/nextcloud/apps/files_external/lib/Lib/Storage/SMB.php","line":292,"function":"getMTime","class":"Icewind\SMB\Native\NativeFileInfo","type":"->","args":[]},{"file":"/var/www/nextcloud/apps/files_external/lib/Lib/Storage/SMB.php","line":277,"function":"shareMTime","class":"OCA\Files_External\Lib\Storage\SMB","type":"->","args":[]},{"file":"/var/www/nextcloud/lib/private/Files/Storage/Common.php","line":452,"function":"stat","class":"OCA\Files_External\Lib\Storage\SMB","type":"->","args":[""]},{"file":"/var/www/nextcloud/apps/files_external/lib/Lib/Storage/SMB.php","line":578,"function":"test","class":"OC\Files\Storage\Common","type":"->","args":[]},{"file":"/var/www/nextcloud/apps/files_external/lib/config.php","line":269,"function":"test","class":"OCA\Files_External\Lib\Storage\SMB","type":"->","args":[" sensitive parameter replaced "," sensitive parameter replaced "]},{"file":"/var/www/nextcloud/apps/files_external/lib/Controller/StoragesController.php","line":256,"function":"getBackendStatus","class":"OC_Mount_Config","type":"::","args":[" sensitive parameters replaced "]},{"file":"/var/www/nextcloud/apps/files_external/lib/Controller/UserGlobalStoragesController.php","line":121,"function":"updateStorageStatus","class":"OCA\Files_External\Controller\StoragesController","type":"->","args":[" sensitive parameters replaced "]},{"file":"/var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php","line":166,"function":"show","class":"OCA\Files_External\Controller\UserGlobalStoragesController","type":"->","args":[6," sensitive parameter replaced ***"]},{"file":"/var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php","line":99,"function":"executeController","class":"OC\AppFramework\Http\Dispatcher","type":"->","args":[{"class":"OCA\Files_External\Controller\UserGlobalStoragesController"},"show"]},{"file":"/var/www/nextcloud/lib/private/AppFramework/App.php","line":126,"function":"dispatch","class":"OC\AppFramework\Http\Dispatcher","type":"->","args":[{"class":"OCA\Files_External\Controller\UserGlobalStoragesController"},"show"]},{"file":"/var/www/nextcloud/lib/private/AppFramework/Routing/RouteActionHandler.php","line":47,"function":"main","class":"OC\AppFramework\App","type":"::","args":["OCA\Files_External\Controller\UserGlobalStoragesController","show",{"class":"OC\AppFramework\DependencyInjection\DIContainer"},{"id":"6","_route":"files_external.user_global_storages.show"}]},{"function":"__invoke","class":"OC\AppFramework\Routing\RouteActionHandler","type":"->","args":[{"id":"6","_route":"files_external.user_global_storages.show"}]},{"file":"/var/www/nextcloud/lib/private/Route/Router.php","line":297,"function":"call_user_func","args":[{"class":"OC\AppFramework\Routing\RouteActionHandler"},{"id":"6","_route":"files_external.user_global_storages.show"}]},{"file":"/var/www/nextcloud/lib/base.php","line":975,"function":"match","class":"OC\Route\Router","type":"->","args":["/apps/files_external/userglobalstorages/6"]},{"file":"/var/www/nextcloud/index.php","line":42,"function":"handleRequest","class":"OC","type":"::","args":[]}],"File":"/var/www/nextcloud/apps/files_external/3rdparty/icewind/smb/src/Exception/Exception.php","Line":30,"CustomMessage":"--"},"userAgent":"Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:67.0) Gecko/20100101 Firefox/67.0","version":"16.0.1.1"}
8. rik26 commented on Jun 5, 2019

   

   rik26

   on Jun 5, 2019

   Last edited by rik26

   More actions

   Ok solved it. I tried to understand how to make a pull request but i'm not a software engineer...
   
   Here is the code i modified :
   
   In 
   /apps/files_external/lib/Lib/Storage/SMB.php :
   
   /**
            * get the best guess for the modification time of the share
            *
            * @return int
            */
           private function shareMTime() {
                   $highestMTime = 0;
                   $files = $this->share->dir($this->root);
                   foreach ($files as $fileInfo) {
                           try {
                                   if ($fileInfo->getMTime() > $highestMTime) {
                                           $highestMTime = $fileInfo->getMTime();
                                   }
                           } catch (NotFoundException $e) {
                                   // Ignore this, can happen on unavailable DFS shares
    -                        }
    +                       } catch (ForbiddenException $e) {
    +                               // Ignore this too : symlink
    +                       }
                   }
                   return $highestMTime;
           }
   
   
   
9. MorrisJobke commented on Jul 2, 2019

   

   MorrisJobke

   on Jul 2, 2019

   Member

   More actions

   The fix by @rik26 is in #16195