Repository navigation
PHP 7.0+ for Nextcloud 14 #7368
Description
I want to bring up the topic of raising the PHP version to 7.0. I collected a list of released PHP packages for the main distributions:
- Ubuntu 16.04 (xenial): 7.0
- Debian 9 (stretch): 7.0
- SUSE Linux Enterprise Server 12 (Web and Scripting Module): 7.0
- CentOS/Red Hat 7: 5.4
- CentOS/Red Hat 7 with RHSCL: 7.1
As you need to use RHSCL anyways on Red Hat to run Nextcloud 13 and before, it only make sense to also raise the required version for Nextcloud. The main reason behind this is proper type hinting of scalar types as well as strict typing. Just today there was another possible bug that would have been found by our CI if strict typing would be set: #7351 (comment)
Compare https://3v4l.org/dmBJK (without strict typing) to https://3v4l.org/msAEZ (with strict typing).
Opinions on this? I guess it is a good way to move forward with our quality goals.
cc @rullzer @LukasReschke @schiessle @karlitschek @blizzz @skjnldsv @juliushaertl @icewind1991 @ChristophWurst @daita @danxuliu
Activity
splitt3r commentedon Dec 3, 2017
Even 7.0 has only 11 month left -> http://php.net/supported-versions.php
karlitschek commentedon Dec 3, 2017
@splitt3r We have to check the supported situation in distribution. Which is usually different then from upstream.
karlitschek commentedon Dec 3, 2017
O.K. Let's move to 7.0+ for 14
LukasReschke commentedon Dec 3, 2017
Oye! NOW the fun stuff starts? ;-)
MorrisJobke commentedon Dec 3, 2017
Our goal is to have a supported version on which Nextcloud runs on all major distributions. Because this is the place where Nextcloud runs and it would not make it easier to get Nextcloud running if you need to find 3rdparty packages or compile PHP yourself. (Not even thinking about security and upgrade problems afterwards with those setups).
rullzer commentedon Dec 3, 2017
Yes please. I think this can really harden our software!
I'm fine with 7.0 for now. We can review for 15 what the state is then.
tflidd commentedon Dec 4, 2017
In NC13, could we put in a notification/warning on the admin page for users with PHP<7.0 that this is the last version supporting php 5.6 and that PHP 7.0+ is required for the next major release? This way they are noticed early enough to plan an upgrade.
MorrisJobke commentedon Dec 4, 2017
Could you make a ticket for this. You could also assign me there. Thanks
Require local phpunit through composer and bump phpunit version
Require local phpunit through composer and bump phpunit version