You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Position of Gallery-button and inconsistent behavior on hover #7374
@skjnldsv that #gallery-button needs to be on the far right. Previously that was done via float: right as you can see from gallery/css/gallerybutton.css. How would we do that now with flexbox and the path? The button should definitely not be inthe left cause it interferes with the Add button.
It should be done with margin-left:auto, but the problem is that it's always renderer before the Add button.
I think this requires rethinking the JS method responsible for painting the gallery-button
Activity
MorrisJobke commentedon Dec 12, 2017
cc @nextcloud/designers @oparoz
jancborchardt commentedon Dec 12, 2017
@skjnldsv that
#gallery-buttonneeds to be on the far right. Previously that was done viafloat: rightas you can see fromgallery/css/gallerybutton.css. How would we do that now with flexbox and the path? The button should definitely not be inthe left cause it interferes with the Add button.pixelipo commentedon Dec 12, 2017
It should be done with margin-left:auto, but the problem is that it's always renderer
beforethe Add button.I think this requires rethinking the JS method responsible for painting the gallery-button
skjnldsv commentedon Dec 12, 2017
I'll take a look if you want @pixelipo
skjnldsv commentedon Dec 13, 2017
Please review :) nextcloud/gallery#336 & #7478