Skip to content

Theming on light color #7401

Description

@tobiasKaminsky

On a very light color, the icons are white, but I think they should be black, or?

image
@juliushaertl @nextcloud/theming

Color is: F9FF00

Activity

  1. self-assigned this
    on Dec 6, 2017
  2. sunjam commented on Dec 8, 2017

    @sunjam

    Allowing clients to optionally set their own custom color from a hex color wheel would be ideal. This is also exactly what is already done for the background color itself.

  3. juliusknorr commented on Jan 4, 2018

    @juliusknorr
    Member

    @sunjam Setting color will not work, since we just invert the icons we have. Changing to custom colors would be a quite big adjustment. Besides that the theming app should provide great default theming without having to mess with many settings.

  4. added this to the Nextcloud 13 milestone on Jan 9, 2018
  5. tobiasKaminsky commented on Jan 10, 2018

    @tobiasKaminsky
    MemberAuthor

    I tested it with latest master and color #F9FF00.
    The top left icons are still white, but top right (search, contacts) are black.

    Is it also possible that the default logo is turned to black if needed?
    image

  6. MorrisJobke commented on Jan 10, 2018

    @MorrisJobke
    Member

    Nope the logo is the logo and will not be adjusted magically. If you theme your Nextcloud you should also adjust the logo to match.

  7. juliusknorr commented on Jan 10, 2018

    @juliusknorr
    Member

    I tested it with latest master and color #F9FF00.
    The top left icons are still white, but top right (search, contacts) are black.

    That's actually an regression. I wonder why this didn't happend to me when testing. Let me have a look.

  8. MorrisJobke commented on Jan 10, 2018

    @MorrisJobke
    Member

    A - I mixed up the top left icons (app icons) with the actual logo (also in the top left) - sorry

  9. tobiasKaminsky commented on Jan 10, 2018

    @tobiasKaminsky
    MemberAuthor

    Nope the logo is the logo and will not be adjusted magically

    This is fine for me. It was just an idea :-)

  10. juliusknorr commented on Jan 10, 2018

    @juliusknorr
    Member

    Finally fixed with #7767

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions