Repository navigation
LDAP error code handling, specify errors that would not end up in a UnavailableServer exception #7675
Description
Activity
@blizzz Still something for 14? Maybe for the polishing phase? Or maybe something for later?
I am off during polishing → 15.
@blizzz Moving to 16.
Reacted by Arthur Schiwon14 remaining items
Seems like this is still valid?
yes, not high on the prio
Reacted by Simon L.- changed the title
[-]LDAP error code handling, follow whitelist strategy instead[/-][+]LDAP error code handling, specify errors that would not end up in a UnavailableServer exception[/+]on Jun 9, 2021 Today got aware about an Operations Error with an invalid LDAP query that materialized through an unexpected configuration (empty user filter). Due to being logged into debug only and a high traffic instance, it was hard to spot, and it did not even surface with a consistent behaviour on the UI side.
In the LDAP Backend we have an wrapper in place that takes care of the error handling. In some occasions, for instance when the server is offline for whatever reason, an exception must be thrown to avoid unpredicatable side effects.
Currently, we hand pick the error cases where an specific expression is thrown, the default is to let them pass through. There are several possible error codes, and as seen in #7662 also some far various states of being effectively offline. The suggestion is to only white list error codes and let only pass those that are acceptable.
It is a hardening approach, as of now no other problems are known by the current approach.