Skip to content

Do not regenerate the preview on a rename #7700

Description

@MorrisJobke
  • having a file with a preview
  • rename the file
  • actual: preview is hidden behind a spinner and then downloaded again
  • expected: preview just stays

The reason for this is, that the preview is actually requested based on the filename and not on the fileid (it is nevertheless stored under the fileid and thus not re-generated).

Before and after rename URL:

http://192.168.99.100/server/core/preview.png?file=%2FBildschirmfoto+2017-11-30+um+23.09.2822.png&c=64e26567fd27cdb34123247436d80d29&x=32&y=32&forceIcon=0
http://192.168.99.100/server/core/preview.png?file=%2FBildschirmfoto+2017-11-30+um+23.09.28224.png&c=64e26567fd27cdb34123247436d80d29&x=32&y=32&forceIcon=0

cc @rullzer @nextcloud/javascript

Activity

  1. rullzer commented on Jan 4, 2018

    @rullzer
    Member

    Well yes. Solution would be to create a new endpoint that accepts a file id. This would not be hard to do. (actually fairly easy).

    This might be enough. Since then the browser knows the fileid hasn't changed so the fetch of the preview is instance (since we cache it :P)

  2. added this to the Nextcloud 14 milestone on Jan 4, 2018
  3. self-assigned this
    on Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementpapercutAnnoying recurring UX issue with possibly simple fix.

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions