Repository navigation
Settings section missing as their classes cannot be resolved by the DI container #7755
Description
Steps to reproduce
- Update to nc13 beta4
- Install news or one of 2fa apps (totp, u2f)
- Find no settings in your personal security section
Expected behaviour
See app's settings section.
Actual behaviour
Section not shown. Does not exist in DB.
Originally reported as nextcloud/twofactor_u2f#83 by @schiessle. Since it's apparently happening for three installed apps, I'm assuming this is a bug in the server components rather than the apps.
"Could not resolve OCA\\\\News\\\\Settings\\\\Section! Class OCA\\\\News\\\\Settings\\\\Section does not exist\"
"Could not resolve OCA\\\\TwoFactorTOTP\\\\Settings\\\\Personal! Class OCA\\\\TwoFactorTOTP\\\\Settings\\\\Personal does not exist\"
"Could not resolve OCA\\\\News\\\\Settings\\\\Section! Class OCA\\\\News\\\\Settings\\\\Section does not exist\"
"Could not resolve OCA\\\\TwoFactorTOTP\\\\Settings\\\\Personal! Class OCA\\\\TwoFactorTOTP\\\\Settings\\\\Personal does not exist\"
Sentry report and stack trace https://sentry.io/share/issue/286d96e539844c288c05d069e097331e/
Database entries
> select * from oc_personal_settings;
+----+--------------------------------------------+----------+----------+
| id | class | section | priority |
+----+--------------------------------------------+----------+----------+
| 1 | OCA\FederatedFileSharing\Settings\Personal | sharing | 40 |
| 2 | OCA\TwoFactorBackupCodes\Settings\Personal | security | 40 |
+----+--------------------------------------------+----------+----------+
2 rows in set (0.01 sec)
cc @blizzz
Activity
blizzz commentedon Jan 9, 2018
Hm, I have news installed and settings are working.
ChristophWurst commentedon Jan 9, 2018
My production instance is on php5.6, if that makes a difference.
ChristophWurst commentedon Jan 9, 2018
There are also no custom classes/interfaces that need to be resolved (which was my first guess for the DI failure): https://github.com/nextcloud/twofactor_totp/blob/master/lib/Settings/Personal.php
blizzz commentedon Jan 9, 2018
not sure, but it is a difference. I am on 7.0 in production. Strange thing.
@schiessle are you also on 5.6?
blizzz commentedon Jan 9, 2018
well, we should catch, log and forget it otherwise
blizzz commentedon Jan 9, 2018
@ChristophWurst do you have a Backtrace?
ChristophWurst commentedon Jan 9, 2018
It's c.nc.com.
https://sentry.io/share/issue/286d96e539844c288c05d069e097331e/
rullzer commentedon Jan 9, 2018
Lets see if I can reproduce this on a clean install...
rullzer commentedon Jan 9, 2018
Boom got it on my dev instance... lets see :)
9 remaining items
ChristophWurst commentedon Jan 9, 2018
I don't really know the code in question, but I'm wondering why we're not failing hard if that occurs:
server/lib/private/Settings/Manager.php
Line 455 in 9386b07
We do log it, yes. But then just carry on as if that's fine. @blizzz are there any cases where it fails and we ca n safely ignore it?
rullzer commentedon Jan 9, 2018
yes:
rullzer commentedon Jan 10, 2018
PR to log as INFO in #7766
rullzer commentedon Jan 10, 2018
@ChristophWurst I think/hope this was a 1 time issue with upgrade of server and update of the apps and something not going quite ok. I have not been able to trigger it since.
If you can please reopen.
blizzz commentedon Jan 10, 2018
For 14? we already thought of removing this from the DB and react on the info.xml only. Wouldn't necessarily be safe from broken DI magic spells whatsoever, but would avoid messy DBs and the tango around it.
schiessle commentedon Feb 6, 2018
I have the same issue now on my instance... updated to Nextcloud 13 and the settings for u2f are gone
[-][13.0beta4] Settings section missing as their classes cannot be resolved by the DI container[/-][+]Settings section missing as their classes cannot be resolved by the DI container[/+]MorrisJobke commentedon Aug 24, 2018
Fixed in 14. It is not cached in the DB anymore.