Skip to content

Issue with login flow #7805

Closed
Closed
Issue with login flow#7805
Labels
3. to reviewWaiting for reviewsbug
Milestone
Nextcloud 13

Description

@mario
mario
opened on Jan 12, 2018

$this->request->getServerProtocol() sometimes report http even if the server is on https?

Maybe proxy or something in the back?

Demo server: https://demo13.nextcloud.bayton.org/login
Username: admin
Pass: admin

Activity

  1. mario commented on Jan 12, 2018

    @mario
    mario
    on Jan 12, 2018
    ContributorAuthor

    I assume we'd need to check HTTP_X_FORWARDED_PROTO and HTTP_X_FORWARDED_SSL too?

  2. MorrisJobke
    added this to the Nextcloud 13 milestone on Jan 12, 2018
  3. MorrisJobke
    added
    bug
    3. to reviewWaiting for reviews
    on Jan 12, 2018

  4. MorrisJobke commented on Jan 14, 2018

    @MorrisJobke
    MorrisJobke
    on Jan 14, 2018
    Member

    Fixed by #7806

  5. MorrisJobke
    closed this as completedon Jan 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    3. to reviewWaiting for reviewsbug

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions