Repository navigation
Clippy icon missing? #7990
Description
Activity
cc @nextcloud/javascript
The missing clipboard icon is a regression; I will take care of it.
Reacted by John Molakvoæ, Thomas Ebert and Roeland Jago DoumaThank you! 😊
While you are here, let me ask one question: Is it sufficient to add the
.clipboardButtonclass (and also thedata-clipboard-targetattribute, of course) to a link to add such button to my own app or will I need a separate script or other classes as well?@danxuliu Any ETA? Because this is the only one, that would block the very last RC before the 13.0.0 release and I would like to get the RC out today or tomorrow.
- added a commit that references this issue
on Jan 24, 2018 Any ETA? Because this is the only one, that would block the very last RC before the 13.0.0 release and I would like to get the RC out today or tomorrow.
Sorry for the delay; it is fixed in #8032 :-)
Is it sufficient to add the .clipboardButton class (and also the data-clipboard-target attribute, of course) to a link to add such button to my own app or will I need a separate script or other classes as well?
If I am not mistaken you would need to, at the very least, create a
Clipboardobject. But you should handle thesuccessevent too to give feedback to the user ;-)- added a commit that references this issue
on Jan 24, 2018 @danxuliu Thank you! It was very hard for me to get the tooltip working, because I couldn't find any documentation (is it Bootstrap-js?). I ended up configuring the tooltip in the render function of my filetabview. Don't know if that's correct, but otherwise the elements were not available in the DOM and it seems you can't configure a tooltip for an element that will be added later.
Aside from that, I can confirm the clipboard icon for sharing works again in RC3. 🎉
I'm not sure if this a bug or just a problem with my local set-up. I'm using NC 13 RC2 on a debian vm in Firefox.
Steps to reproduce (Example)
Expected behaviour
The clippy symbol is in the right corner of the url field, on hover it says “copy” and on click it copies the url into the clipboard and the popover text reads “copied”.
Actual behaviour
The icon is missing.
Tried to re-clone (from git) already and also disabled all 3rd party apps.
Also, I would like to use the clipboard-icon in my own app, I simply added the
clipboardButtonclass, but I hit several problems:In files_sharing: in NC13 RC2 the clipboard button is missing completely.
In files_sharing: in NC12 everything works as expected.
In my own app: in NC13 RC2 the pop-over works when clicking, but not when hovering.
in my own app: in NC12 the pop-over doesn't work altogether
This is so confusing. If I'm the only one having this problem with NC13 RC2, I'll close this issue again, but I'm curious how it looks for you.