Skip to content

icon-white class doesn't work on IE11 #8702

Closed
#10311
Closed
icon-white class doesn't work on IE11#8702
#10311
Labels
1. to developAccepted and waiting to be taken care ofbugdesignDesign, UI, UX, etc.
Milestone
Nextcloud 14

Description

@juliusknorr
juliusknorr
opened on Mar 7, 2018

Since IE11 is still supported we cannot use the .icon-white class as added in #7319, since filter:invert(100%); is not supported: https://caniuse.com/#search=invert

A possible solution would be to use something like https://github.com/shekhardesigner/InvertImages to provide a fallback solution for IE11. We could even simplify the script a bit: https://github.com/shekhardesigner/InvertImages/blob/master/jquery.invertImages.js

@nextcloud/designers @pixelipo

Activity

  1. juliusknorr
    added
    bug
    designDesign, UI, UX, etc.
    1. to developAccepted and waiting to be taken care of
    on Mar 7, 2018
  2. nextcloud-bot
    added
    staleTicket or PR with no recent activity
    on Jun 20, 2018

  3. jancborchardt commented on Jun 23, 2018

    @jancborchardt
    jancborchardt
    on Jun 23, 2018
    Member

    cc @skjnldsv @nextcloud/designers since we talked about this in the #9862 accessibility pull request.

  4. nextcloud-bot
    removed
    staleTicket or PR with no recent activity
    on Jun 23, 2018

  5. MorrisJobke commented on Jun 25, 2018

    @MorrisJobke
    MorrisJobke
    on Jun 25, 2018
    Member

    Fix is in #9984

  6. MorrisJobke
    closed this as completedin #9984on Jul 19, 2018

  7. juliusknorr commented on Jul 20, 2018

    @juliusknorr
    juliusknorr
    on Jul 20, 2018
    MemberAuthor

    Not yet fixed, #9984 is the foundation of it, we still need to get rid of the invert filter and load the icons with white color for the icon-white class. I'll have a look.

  8. juliusknorr
    reopened this on Jul 20, 2018
  9. MorrisJobke
    closed this as completedin #10311on Jul 20, 2018
  10. MorrisJobke
    added this to the Nextcloud 14 milestone on Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    1. to developAccepted and waiting to be taken care ofbugdesignDesign, UI, UX, etc.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions