Skip to content

Comments with mentions look broken in the comments view #9273

Description

@nickvergessen

Activity view

bildschirmfoto von 2018-04-23 12-33-43

Comments view

bildschirmfoto von 2018-04-23 12-33-47

It seems to be broken, because the author information row uses the same CSS classes as the inline mentions. (width 100%, etc.), see Nextcloud 13 for help how it should look

cc @nextcloud/designers

Activity

  1. added this to the Nextcloud 14 milestone on Apr 23, 2018
  2. danxuliu commented on Apr 23, 2018

    @danxuliu
    Member

    Avatars are going to be removed from mentions in comments (and then I guess that we should remove them from the activity view too) so that should implicitly fix this issue.

  3. nickvergessen commented on Apr 23, 2018

    @nickvergessen
    MemberAuthor

    Okay, so let's keep this issue, to make sure this gets addressed before we release something.

  4. jancborchardt commented on May 30, 2018

    @jancborchardt
    Member

    Looking at the Riot redesign, the avatars in mentions look pretty great:

    Sorry for picking this up again @nextcloud/designers (especially @pixelipo ;) but it seems we just need to find the right adjustment – like with putting a container with slight grey background around the avatar and name – and then it looks great.

  5. MorrisJobke commented on Jul 25, 2018

    @MorrisJobke
    Member

    Fixed by #10288

    bildschirmfoto 2018-07-25 um 14 32 01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions