Deprecate scss variables in favour of css #9940

Activity

1. skjnldsv

   added

   designDesign, UI, UX, etc.Design, UI, UX, etc.

   feature: scss

   standardization

   on Jun 20, 2018
2. skjnldsv

   added this to the Netcloud 15 milestone on Jun 20, 2018
3. skjnldsv

   self-assigned this

   on Jun 20, 2018
4. skjnldsv

   added

   1. to developAccepted and waiting to be taken care ofAccepted and waiting to be taken care of

   on Jun 20, 2018
5. nextcloud-bot commented on Jun 20, 2018

   

   nextcloud-bot

   on Jun 20, 2018

   Member

   More actions

   GitMate.io thinks possibly related issues are #3256 (Scss variables), #1786 (Switching to scss), #5395 (Race condition in SCSS generation), #5356 (Deprecated message lazyLoadPreview()), and #5138 (SCSS not working after reboot).
6. MorrisJobke

   added

   technical debt🧱 🤔🚀🧱 🤔🚀

   on Jul 4, 2018
7. MorrisJobke

   modified the milestones: Nextcloud 15, Nextcloud 16 on Nov 7, 2018
8. MorrisJobke commented on Nov 7, 2018

   

   MorrisJobke

   on Nov 7, 2018

   Member

   More actions

   This one didn't made it to 15 - let's move it to 16.

   👍React with 👍1Reacted by John Molakvoæ
9. MorrisJobke commented on Feb 25, 2019

   

   MorrisJobke

   on Feb 25, 2019

   Member

   More actions

   Let's move it to 17.
10. MorrisJobke

    modified the milestones: Nextcloud 16, Nextcloud 17 on Feb 25, 2019
11. rullzer

    removed this from the Nextcloud 17 milestone on Sep 26, 2019
12. 27 remaining items

    Load more
13. skjnldsv

    added this to the Nextcloud 23 milestone on May 26, 2021
14. ChristophWurst commented on Jul 5, 2021

    

    ChristophWurst

    on Jul 5, 2021

    Member

    More actions

    @skjnldsv I would like to push forward with this. Can we declare the scss stuff as deprecated for 22 since we droped IE11? This still gives everyone three years of migration period in theory. So I would like to see this rather sooner than later :)

    👍React with 👍2Reacted by John Molakvoæ
15. skjnldsv commented on Jul 5, 2021

    

    skjnldsv

    on Jul 5, 2021

    MemberAuthor

    More actions

    Sure, we can do that for 23 and remove the variables.scss from the default import

    server/lib/private/Template/SCSSCacher.php

    Line 340 in 0447b53

    '@import "variables.scss";' .

    
    

    server/autotest-js.sh

    Line 31 in 9de329a

    printf "\$webroot:''; @import 'functions.scss'; @import 'variables.scss'; @import '${FILE}';" | ./build/bin/node-sass --include-path core/css/ > tests/css/${FILE}.css

    
    

    server/apps/accessibility/lib/Controller/AccessibilityController.php

    Line 143 in 0447b53

    '@import "variables.scss";' .

    Feel free to push forward.
    It will throw hard for all scss that uses that.
    Then the following step is nuking:

    1. the svg colour api
    2. the on-the-fly scss compiler and have a dedicated npm/bash step to compile all scss?
16. ChristophWurst commented on Jul 5, 2021

    

    ChristophWurst

    on Jul 5, 2021

    Member

    More actions

    @skjnldsv I'm not talking about taking action. I meant to say that we add a formal note about this transition to https://docs.nextcloud.com/server/latest/developer_manual/app_publishing_maintenance/upgrade-guide.html saying that this mechanism is expected to go away
17. skjnldsv commented on Jul 5, 2021

    

    skjnldsv

    on Jul 5, 2021

    MemberAuthor

    More actions

    Sure thing! Please do!

    🚀React with 🚀1
18. skjnldsv

    removed their assignment

    on Jul 5, 2021
19. blizzz

    modified the milestones: Nextcloud 23, Nextcloud 24 on Nov 30, 2021
20. nickvergessen

    assigned

    skjnldsv

    on Mar 29, 2022
21. skjnldsv

    modified the milestones: Nextcloud 24, Nextcloud 25 on Mar 29, 2022
22. skjnldsv

    added

    4. to releaseReady to be released and/or waiting for tests to finishReady to be released and/or waiting for tests to finish

    and removed

    1. to developAccepted and waiting to be taken care ofAccepted and waiting to be taken care of

    on Aug 13, 2022
23. skjnldsv commented on Aug 13, 2022

    

    skjnldsv

    on Aug 13, 2022

    MemberAuthor

    More actions

    Removed in 25

    nextcloud/documentation#9136
24. skjnldsv

    closed this as completedon Aug 13, 2022