Skip to content

Fix avatar sizing for comments - #10394

Merged
MorrisJobke merged 2 commits into
masterfrom
bugfix/10381/fix-avatar-sizing
Jul 25, 2018
Merged

MorrisJobke merged 2 commits into
masterfrom
bugfix/10381/fix-avatar-sizing

Conversation

@juliusknorr

Copy link
Copy Markdown
Member
  • Limit small avatar rendering only to inline mentions
  • Use small loading indicator for avatars smaller than 32px

The overlay in the loading preview is only caused by the browser when stopping the execution to make a screenshot. 😉
Before:
image
image

After:
image
image

Fixes #10381

@juliusknorr juliusknorr added design Design, UI, UX, etc. 3. to review Waiting for reviews regression labels Jul 25, 2018
@juliusknorr juliusknorr added this to the Nextcloud 14 milestone Jul 25, 2018

@MorrisJobke MorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke mentioned this pull request Jul 25, 2018
15 of 21 tasks

@skjnldsv skjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it so much!! such tiny stuff yet so great addition! :D

@MorrisJobke
MorrisJobke requested review from rullzer and skjnldsv July 25, 2018 12:47
@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 25, 2018
@MorrisJobke

MorrisJobke commented Jul 25, 2018 •

Copy link
Copy Markdown
Member

@MorrisJobke
MorrisJobke merged commit cf98d9c into master Jul 25, 2018
@MorrisJobke
MorrisJobke deleted the bugfix/10381/fix-avatar-sizing branch July 25, 2018 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish design Design, UI, UX, etc. regression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants