Skip to content

Use flexbox on app page - #1355

Merged
MorrisJobke merged 2 commits into
masterfrom
apps_flexbox
Oct 26, 2016
Merged

MorrisJobke merged 2 commits into
masterfrom
apps_flexbox

Conversation

@rullzer

@rullzer rullzer commented Sep 10, 2016 •

Copy link
Copy Markdown
Member

The amount of white space on the app page was annoying me. So I decided to give flexbox a try.

Before:
before

After:
after

Which looks a lot better to me.

However it does need work as you can see on the notenabled page:
not_enabled

Far from done.

  • Experimental apps display
  • Fix per app layout a bit more
  • Full Safari/IE support
  • Restrict to apps only (currently affects personal/admin settings, too)

CC: @nextcloud/designers @MorrisJobke

@rullzer rullzer added enhancement help wanted design Design, UI, UX, etc. 1. to develop Accepted and waiting to be taken care of 2. developing Work in progress labels Sep 10, 2016
@rullzer rullzer added this to the Nextcloud 11.0 milestone Sep 10, 2016
@mention-bot

Copy link
Copy Markdown

@rullzer, thanks for your PR! By analyzing the annotation information on this pull request, we identified @jancborchardt, @MorrisJobke and @DeepDiver1975 to be potential reviewers

@raghunayyar

Copy link
Copy Markdown
Member

Personally, I find it a bit too noisy now since the left ones have the heading on the left and the centre ones have the heading below the image. There is no visual consistency here. May be you want to use two of them instead of the three and make sure the image comes on the left and the content on the right.

@raghunayyar

Copy link
Copy Markdown
Member

Aaah, I missed the second image. Never mind. :P

@tcitworld

Copy link
Copy Markdown
Member

I think margin for only two columns would be fine.

@eppfel

eppfel commented Sep 10, 2016

Copy link
Copy Markdown
Member

I like the idea, but it could really be a bit too "noisy". The styling of the per app layout is not so easy, because these are inline-box elements right now.
Experimental apps are separated now:
bildschirmfoto 2016-09-10 um 17 06 16
bildschirmfoto 2016-09-10 um 17 06 30

@rullzer

rullzer commented Sep 10, 2016

Copy link
Copy Markdown
Member Author

Thanks for the feedback. I just wanted to get things started. As I have the artistic insight of a table I'll happily hand this over :) I just found that the current design had way to much wasted space.

@eppfel thnx!

@eppfel

eppfel commented Sep 11, 2016

Copy link
Copy Markdown
Member

My try in making it less noisy:
bildschirmfoto 2016-09-11 um 11 49 33
bildschirmfoto 2016-09-11 um 11 51 57

I think the elements of each app have to be rearranged for a proper overall look. Maybe we have to take the design of the app store into account as well: https://apps.nextcloud.com/

@MariusBluem MariusBluem removed the 1. to develop Accepted and waiting to be taken care of label Sep 11, 2016
@jancborchardt

Copy link
Copy Markdown
Member

@eppfel looks awesome! (Did I ask you already if you’re going to come to the Nextcloud conference?) ;)

@eppfel

eppfel commented Sep 12, 2016

Copy link
Copy Markdown
Member

@jancborchardt You did and I will 😉

@jancborchardt

Copy link
Copy Markdown
Member

@eppfel @rullzer is a first version of this ready for getting in, or where do you need help? We should merge it to master soon so we can see how it works and polish it for Nextcloud 11. :)

Comment thread settings/css/settings.css Outdated
margin: 0;
border-color: #eee;
border-width: 0 1px 1px 0;
border-style: solid;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tabs vs spaces ;)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sry, fixed

@eppfel

eppfel commented Oct 18, 2016

Copy link
Copy Markdown
Member

@jancborchardt It needs to be fixed, because right now it affects the personal settings page as well. Besides that, the flexing seems robust, but the current version still has borders and I would like to get another opinion on that besides yours ;) Maybe there is time during the meetup, but otherwise the week is packed tight.

@MorrisJobke

Copy link
Copy Markdown
Member

@eppfel Ready to review? Then change the label ;)

MorrisJobke
MorrisJobke previously approved these changes Oct 18, 2016
@MorrisJobke
MorrisJobke dismissed their stale review October 18, 2016 15:49

Was temporarily

@eppfel

eppfel commented Oct 18, 2016

Copy link
Copy Markdown
Member

@MorrisJobke Not, yet. I just fixed the spaces with an evil force push. But pssst 🙊 don't tell anyone

@eppfel eppfel self-assigned this Oct 18, 2016
@jancborchardt

Copy link
Copy Markdown
Member

@MorrisJobke do you have any take on grid lines vs no grid lines? As @eppfel asked above ;)

@MorrisJobke

Copy link
Copy Markdown
Member

@MorrisJobke do you have any take on grid lines vs no grid lines? As @eppfel asked above ;)

I would either go with a higher padding of 40px and no grid lines or leave the grid lines and 30px padding. The higher padding is needed to compensate for the missing visual guidelines. Generally speaking I like the no-gridlines version more, because we only have the line for the sidebar and horizontal lines in the files app for example, but never used vertical grid lines.

@jancborchardt

Copy link
Copy Markdown
Member

@eppfel you wanna try out the higher padding? Then let’s get this in and refine later. I’d hate to have this great improvement laying around for too long. ;)

@eppfel

eppfel commented Oct 24, 2016

Copy link
Copy Markdown
Member

Jep. I'll try that out. Was just a crazy last week, no time at all.

Let app-name headline break, increase padding on the right for more visual clearance.
Make experimental header full width

Signed-off-by: Felix A. Epp <[email protected]>
@eppfel

eppfel commented Oct 25, 2016

Copy link
Copy Markdown
Member

I only used the padding-right, but 50px, because this side has no sharp edge. Works for me, but I will open another issue for organizing the elements of each app.
I squashed my commits, so ready for gogo!

@eppfel eppfel added 3. to review Waiting for reviews and removed 2. developing Work in progress help wanted labels Oct 25, 2016
@LukasReschke

Copy link
Copy Markdown
Member

LGTM

@MorrisJobke

Copy link
Copy Markdown
Member

Tested and works 👍

Tested in Firefox, Chrome, Safari, IE11 and Edge

@MorrisJobke
MorrisJobke merged commit 3636182 into master Oct 26, 2016
@MorrisJobke
MorrisJobke deleted the apps_flexbox branch October 26, 2016 08:28
@jancborchardt

jancborchardt commented Oct 27, 2016 •

Copy link
Copy Markdown
Member

Awesome work @eppfel @rullzer! :) 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews design Design, UI, UX, etc. enhancement high

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants