Skip to content

Provide a PHP Api for UserStatus - #22106

Merged
MorrisJobke merged 1 commit into
masterfrom
feature/noid/user_status_api
Aug 5, 2020
Merged

Provide a PHP Api for UserStatus#22106
MorrisJobke merged 1 commit into
masterfrom
feature/noid/user_status_api

Conversation

@georgehrke

@georgehrke georgehrke commented Aug 4, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

This PR provides a PHP API for the new User Status feature.
It allows apps to query the status for a batch of users.

@georgehrke georgehrke added the 2. developing Work in progress label Aug 4, 2020
@georgehrke

georgehrke commented Aug 4, 2020

Copy link
Copy Markdown
Member Author

@nickvergessen Does this look reasonable for your use-case in Talk?

georgehrke
georgehrke commented Aug 4, 2020
View reviewed changes
Comment thread apps/user_status/lib/Connector/UserStatus.php Outdated
@georgehrke
georgehrke force-pushed the feature/noid/user_status_api branch from 7948aeb to c464e09 Compare August 4, 2020 20:01
@georgehrke georgehrke mentioned this pull request Aug 5, 2020
Closed
8 tasks done
georgehrke
georgehrke commented Aug 5, 2020
View reviewed changes
Comment thread apps/user_status/lib/Connector/UserStatusProvider.php Outdated
georgehrke
georgehrke commented Aug 5, 2020
View reviewed changes
Comment thread apps/user_status/lib/Connector/UserStatus.php
@georgehrke
georgehrke force-pushed the feature/noid/user_status_api branch from c464e09 to 905bfd3 Compare August 5, 2020 08:45
@georgehrke georgehrke mentioned this pull request Aug 5, 2020
Merged
@georgehrke georgehrke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 5, 2020
@georgehrke
georgehrke force-pushed the feature/noid/user_status_api branch from 905bfd3 to 17bbadd Compare August 5, 2020 09:54
@georgehrke

georgehrke commented Aug 5, 2020

Copy link
Copy Markdown
Member Author

upon the request of @nickvergessen, i changed it from IUser to userId

nickvergessen
nickvergessen reviewed Aug 5, 2020
View reviewed changes
Comment thread lib/public/UserStatus/IManager.php Outdated
nickvergessen
nickvergessen reviewed Aug 5, 2020
View reviewed changes
Comment thread lib/public/UserStatus/IUserStatus.php Outdated
@georgehrke georgehrke added this to the Nextcloud 20 milestone Aug 5, 2020
@georgehrke
georgehrke force-pushed the feature/noid/user_status_api branch from 1835c19 to 0e0e0d1 Compare August 5, 2020 11:49
nickvergessen
nickvergessen approved these changes Aug 5, 2020
View reviewed changes

@nickvergessen nickvergessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦈

@nickvergessen nickvergessen mentioned this pull request Aug 5, 2020
Merged
2 of 3 tasks
@faily-bot

faily-bot Bot commented Aug 5, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 31402: failure

mysql8.0-php7.2

Show full log 
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Files\Cache\ScannerTest::testReuseExisting
Failed asserting that null is of type "string".

/drone/src/tests/lib/Files/Cache/ScannerTest.php:253

MorrisJobke
MorrisJobke approved these changes Aug 5, 2020
View reviewed changes

@MorrisJobke MorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍

@MorrisJobke
MorrisJobke merged commit 6fbf8fc into master Aug 5, 2020
@MorrisJobke
MorrisJobke deleted the feature/noid/user_status_api branch August 5, 2020 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes
@MorrisJobke MorrisJobke MorrisJobke approved these changes
@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

No one assigned

Labels

3. to review Waiting for reviews feature: status

Projects

None yet

Milestone

Nextcloud 20

Development

Successfully merging this pull request may close these issues.

3 participants

@georgehrke @nickvergessen @MorrisJobke