Skip to content

make the share icon in the filelist visible again - #2278

Merged
LukasReschke merged 2 commits into
masterfrom
filelist-share-visible
Nov 23, 2016
Merged

LukasReschke merged 2 commits into
masterfrom
filelist-share-visible

Conversation

@icewind1991

Copy link
Copy Markdown
Member

Fixes #2277

cc @LukasReschke

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Nov 23, 2016
@icewind1991 icewind1991 added this to the Nextcloud 11.0 milestone Nov 23, 2016
@mention-bot

Copy link
Copy Markdown

@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jancborchardt, @PVince81 and @MorrisJobke to be potential reviewers.

@LukasReschke LukasReschke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LukasReschke

Copy link
Copy Markdown
Member

Works fine LGTM

@skjnldsv

Copy link
Copy Markdown
Member

👍

@LukasReschke LukasReschke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 23, 2016
@MorrisJobke

Copy link
Copy Markdown
Member

The hover style doesn't work anymore - I will fix this in here too.

@MorrisJobke

Copy link
Copy Markdown
Member

Tested and works now 👍

The style is now darker when hovered/focused and existing shares are also darker. Also when hovering the menu icon it's shown darker. ;)

@skjnldsv

Copy link
Copy Markdown
Member

Perfect! 👍

@LukasReschke
LukasReschke merged commit 6d92550 into master Nov 23, 2016
@LukasReschke
LukasReschke deleted the filelist-share-visible branch November 23, 2016 15:40
@jancborchardt

Copy link
Copy Markdown
Member

Thanks, that was of course not intentional. :D Thought it was an Adblock plus thing again initially.

@skjnldsv

Copy link
Copy Markdown
Member

@jancborchardt We all know you dit it! Don't lie!

@jancborchardt

Copy link
Copy Markdown
Member

@skjnldsv maybe it’s time to start using PhantomCSS or smth like that https://css-tricks.com/visual-regression-testing-with-phantomcss/ :D

@skjnldsv

Copy link
Copy Markdown
Member

Isn't there too much hidden stuff on nextcloud to implement this?

@jancborchardt

Copy link
Copy Markdown
Member

Probably yes – all these visual CI systems seem to be mainly for static websites without much JS or interactivity. :\

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants