Repository navigation
make the share icon in the filelist visible again - #2278
Conversation
Signed-off-by: Robin Appelman <[email protected]>
|
@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jancborchardt, @PVince81 and @MorrisJobke to be potential reviewers. |
|
Works fine LGTM |
|
👍 |
|
The hover style doesn't work anymore - I will fix this in here too. |
Signed-off-by: Morris Jobke <[email protected]>
|
Tested and works now 👍 The style is now darker when hovered/focused and existing shares are also darker. Also when hovering the menu icon it's shown darker. ;) |
|
Perfect! 👍 |
|
Thanks, that was of course not intentional. :D Thought it was an Adblock plus thing again initially. |
|
@jancborchardt We all know you dit it! Don't lie! |
|
@skjnldsv maybe it’s time to start using PhantomCSS or smth like that https://css-tricks.com/visual-regression-testing-with-phantomcss/ :D |
|
Isn't there too much hidden stuff on nextcloud to implement this? |
|
Probably yes – all these visual CI systems seem to be mainly for static websites without much JS or interactivity. :\ |
Fixes #2277
cc @LukasReschke