Repository navigation
Fix input field for new folder - #2470
Merged
Merged
Conversation
Signed-off-by: Morris Jobke <[email protected]>
|
@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jancborchardt, @butonic and @Bagera to be potential reviewers. |
Member
Author
|
Tested in Firefox, Chrome, IE11, Edge, Safari |
Signed-off-by: Jan-Christoph Borchardt <[email protected]>
Member
|
👍 nice work. I also added a commit to fix the vertical expansion of the popover because the input element was higher than the text. |
Member
Author
|
Nice @jancborchardt 👍 |
Member
|
Works, should we make the dropdown a bit bigger? |
Member
Author
Let me add this quickly. |
Signed-off-by: Morris Jobke <[email protected]>
Member
Author
|
@nickvergessen Please retest |
Member
|
much better 👍 |
Current coverage is 57.08% (diff: 100%)@@ master #2470 diff @@
==========================================
Files 1198 1198
Lines 72247 72247
Methods 7347 7347
Messages 0 0
Branches 1216 1216
==========================================
- Hits 41240 41239 -1
- Misses 31007 31008 +1
Partials 0 0
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @nickvergessen @rullzer @nextcloud/designers @skjnldsv @juliushaertl