Skip to content

use unmasked permissions in shared scanner - #2673

Merged
LukasReschke merged 2 commits into
masterfrom
shared-scanner-unmasked
Dec 15, 2016
Merged

use unmasked permissions in shared scanner#2673
LukasReschke merged 2 commits into
masterfrom
shared-scanner-unmasked

Conversation

@icewind1991

@icewind1991 icewind1991 commented Dec 14, 2016

Copy link
Copy Markdown
Member

Fixes #2658

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Dec 14, 2016
@icewind1991
icewind1991 requested a review from rullzer December 14, 2016 13:41
@mention-bot

mention-bot commented Dec 14, 2016

Copy link
Copy Markdown

@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rullzer, @schiessle and @MTGap to be potential reviewers.

@rullzer

rullzer commented Dec 14, 2016

Copy link
Copy Markdown
Member

Good stuff! Works and fixes the issue!

@LukasReschke @MorrisJobke @nickvergessen please have a look.

@rullzer rullzer mentioned this pull request Dec 14, 2016
Closed
LukasReschke
LukasReschke requested changes Dec 14, 2016
View reviewed changes

@LukasReschke LukasReschke left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add an actual integration test using HTTP requests? – I won't accept it like that due to the risk of regressions. Thanks.

@nickvergessen nickvergessen added this to the Nextcloud 12.0 milestone Dec 15, 2016
@icewind1991

icewind1991 commented Dec 15, 2016

Copy link
Copy Markdown
Member Author

@LukasReschke done

@LukasReschke

LukasReschke commented Dec 15, 2016

Copy link
Copy Markdown
Member

Thanks, @icewind1991.

Can you also add one for the original issue from #2486 / https://hackerone.com/reports/169680 ?

@icewind1991

icewind1991 commented Dec 15, 2016

Copy link
Copy Markdown
Member Author

Can you also add one for the original issue from #2486 / https://hackerone.com/reports/169680 ?

No, since the route that triggered that doesn't exist in 11 (upload.php)

@LukasReschke

LukasReschke commented Dec 15, 2016

Copy link
Copy Markdown
Member

Fair enough.

@LukasReschke
LukasReschke merged commit 5b474e7 into master Dec 15, 2016
@LukasReschke
LukasReschke deleted the shared-scanner-unmasked branch December 15, 2016 14:54
@LukasReschke

LukasReschke commented Dec 15, 2016

Copy link
Copy Markdown
Member

I suppose this requires backports? :)

@icewind1991

icewind1991 commented Dec 15, 2016 •
edited
Loading

Copy link
Copy Markdown
Member Author

stable11 only afaik

11 and 10

This was referenced Dec 15, 2016
Merged
Merged
@icewind1991

icewind1991 commented Dec 15, 2016

Copy link
Copy Markdown
Member Author

stable10: #2697
stable11: #2696

@karlitschek

karlitschek commented Dec 15, 2016

Copy link
Copy Markdown
Member

backport makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes
@LukasReschke LukasReschke LukasReschke approved these changes

Assignees

No one assigned

Labels

2. developing Work in progress feature: filesystem feature: sharing

Projects

None yet

Milestone

Nextcloud 12.0

Development

Successfully merging this pull request may close these issues.

6 participants

@icewind1991 @mention-bot @rullzer @LukasReschke @karlitschek @nickvergessen