Skip to content

Reply with json when not accepting html on LoginException - #26846

Merged
MorrisJobke merged 2 commits into
masterfrom
followup/26572/reply-with-json-when-not-accepting-html
May 17, 2021
Merged

MorrisJobke merged 2 commits into
masterfrom
followup/26572/reply-with-json-when-not-accepting-html

Conversation

@nickvergessen

Copy link
Copy Markdown
Member

Follow up to #26572

@korelstar korelstar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the problem. Thanks for the quick response!

@MorrisJobke MorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

Comment thread index.php

@MorrisJobke MorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline

@nickvergessen
nickvergessen requested a review from MorrisJobke May 3, 2021 14:14
@korelstar

Copy link
Copy Markdown
Member

Ping @MorrisJobke
I'm looking forward for getting this merged :-)

Comment thread build/integration/features/provisioning-v1.feature Outdated
@nickvergessen
nickvergessen force-pushed the followup/26572/reply-with-json-when-not-accepting-html branch from e779eb6 to 236f1b6 Compare May 12, 2021 06:03
@nickvergessen
nickvergessen requested a review from MorrisJobke May 12, 2021 06:06

@MorrisJobke MorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me 👍

@MorrisJobke
MorrisJobke merged commit 77a4368 into master May 17, 2021
@MorrisJobke
MorrisJobke deleted the followup/26572/reply-with-json-when-not-accepting-html branch May 17, 2021 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants