Skip to content

Add files:scanAppData command - #3995

Merged
LukasReschke merged 2 commits into
masterfrom
files_scan_appdata
Mar 23, 2017
Merged

LukasReschke merged 2 commits into
masterfrom
files_scan_appdata

Conversation

@rullzer

@rullzer rullzer commented Mar 22, 2017

Copy link
Copy Markdown
Member

Fixes #3041

Add a dedicated command to scan the special appdata dir

Fixes #3041

Add a dedicated command to scan the special appdata dir

Signed-off-by: Roeland Jago Douma <[email protected]>
@rullzer rullzer added 3. to review Waiting for reviews enhancement labels Mar 22, 2017
@rullzer rullzer added this to the Nextcloud 12.0 milestone Mar 22, 2017
@mention-bot

Copy link
Copy Markdown

@rullzer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen, @LukasReschke and @icewind1991 to be potential reviewers.

Comment thread apps/files/lib/Command/ScanAppData.php Outdated
parent::configure();

$this
->setName('files:scanAppData')

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would vote for files:scan-app-data to have a common naming schema

Comment thread apps/files/lib/Command/ScanAppData.php Outdated
$verbose = $input->getOption('verbose');
$quiet = $input->getOption('quiet');
# restrict the verbosity level to VERBOSITY_VERBOSE
if ($output->getVerbosity()>OutputInterface::VERBOSITY_VERBOSE) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spaces around operator

@MorrisJobke

Copy link
Copy Markdown
Member

And of course the autoloader is not updated. Let me address all the comments.

@MorrisJobke

Copy link
Copy Markdown
Member

And of course the autoloader is not updated. Let me address all the comments.

Ah no - it's in files and not needed therefore.

@MorrisJobke MorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works

@LukasReschke
LukasReschke merged commit f38d36a into master Mar 23, 2017
@LukasReschke
LukasReschke deleted the files_scan_appdata branch March 23, 2017 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants