Repository navigation
feat: allow external drop and add dropzone - #40674
Merged
Merged
Conversation
skjnldsv
force-pushed
the
feat/drop-folder
branch
from
September 28, 2023 08:33
9bfc649 to
8b20faa
Compare
skjnldsv
requested review from
a team,
Pytal,
artonge and
susnux
and removed request for
a team
September 28, 2023 08:33
Member
|
How does it handle rich workspaces? |
This comment was marked as resolved.
This comment was marked as resolved.
artonge
approved these changes
Sep 28, 2023
artonge
left a comment
Collaborator
There was a problem hiding this comment.
Code looks good, but not a fan of how it looks :/
Have we looked at how others are doing it ?
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Pytal
approved these changes
Sep 28, 2023
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
skjnldsv
commented
Oct 10, 2023
skjnldsv
force-pushed
the
feat/drop-folder
branch
from
October 10, 2023 10:16
8b20faa to
e7d5d54
Compare
Member
Author
|
@nimishavijay @jancborchardt please advise updated design in the first comment! |
skjnldsv
force-pushed
the
feat/drop-folder
branch
from
October 10, 2023 12:09
e7d5d54 to
0735ec5
Compare
Member
Author
Design tuning can/will be a followup though |
Member
Member
Author
Those two colours doesn't really go together? Is this a mistake? :) |
Signed-off-by: John Molakvoæ <[email protected]>
skjnldsv
force-pushed
the
feat/drop-folder
branch
from
October 10, 2023 13:40
0735ec5 to
35aed73
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fix #4483
@nextcloud/designers for visual input