Repository navigation
replace name in top right with icon for less noise - #4074
Conversation
Signed-off-by: Jan-Christoph Borchardt <[email protected]>
jancborchardt
added
3. to review
|
@jancborchardt, thanks for your PR! By analyzing the history of the files in this pull request, we identified @juliushaertl, @skjnldsv and @ChristophWurst to be potential reviewers. |
|
looks good 👍 |
| </div> | ||
| <span id="expandDisplayName"><?php p(trim($_['user_displayname']) != '' ? $_['user_displayname'] : $_['user_uid']) ?></span> | ||
| <div class="icon-caret"></div> | ||
| <div id="expandDisplayName" class="icon-settings-white"></div> |
There was a problem hiding this comment.
if we don't need user_displayname inside the template now, we should remove it from wherever it is set.
There was a problem hiding this comment.
same with the other variables
There was a problem hiding this comment.
It’s set in the <head>, but I’m not sure if it’s safe to remove there since it might be used by other aspects and apps, no?
There was a problem hiding this comment.
I would leave it for now, because I guess it's set in the general template.
Codecov Report
@@ Coverage Diff @@
## master #4074 +/- ##
============================================
+ Coverage 54.24% 54.24% +<.01%
Complexity 21285 21285
============================================
Files 1310 1310
Lines 81187 81187
Branches 1284 1284
============================================
+ Hits 44036 44037 +1
+ Misses 37151 37150 -1
Continue to review full report at Codecov.
|
|
What about showing the gear for every user and profile picture and name in the popover (as I have proposed over here: #3273 (comment)) ... otherwise, it is complicated to see who is logged in for users without profile picture 😬 |
If you show the gear only for every user then it is very complicated to see who is logged in, even if you have a profile picture. Discussion about additionally showing the name is separate. |
7 participants
Before with profile image and without (long names were not ellipsized which also caused problems like #3273):
After, with profile image and without:
A lot simpler, a lot less elements. As discussed @karlitschek, please review @nextcloud/designers
Another good point is that we always know how far the elements like notifications menu etc are from the right, regarding arrow placement.