Skip to content

Fix pop over menu opacity - #4082

Merged
skjnldsv merged 2 commits into
masterfrom
fix-menu
Mar 28, 2017
Merged

skjnldsv merged 2 commits into
masterfrom
fix-menu

Conversation

@MorrisJobke

Copy link
Copy Markdown
Member

Before:

bildschirmfoto 2017-03-26 um 14 10 34

bildschirmfoto 2017-03-26 um 14 10 37

After:

bildschirmfoto 2017-03-26 um 14 10 10

bildschirmfoto 2017-03-26 um 14 10 13

Fixes #3522

cc @nextcloud/designers @ChristophWurst @nickvergessen @rullzer @skjnldsv @juliushaertl

Signed-off-by: Morris Jobke <[email protected]>
@MorrisJobke MorrisJobke added 3. to review Waiting for reviews design Design, UI, UX, etc. regression labels Mar 26, 2017
@MorrisJobke MorrisJobke added this to the Nextcloud 12.0 milestone Mar 26, 2017
@mention-bot

Copy link
Copy Markdown

@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jancborchardt, @skjnldsv and @juliushaertl to be potential reviewers.

@MorrisJobke

Copy link
Copy Markdown
Member Author

In comparison to #3728 this PR here doesn't change the opacity of the permanent entries in the file list itself and it additionally also fixes other pop over menus, because they were also greyed out.

@MorrisJobke

Copy link
Copy Markdown
Member Author

it additionally also fixes other pop over menus, because they were also greyed out.

bildschirmfoto 2017-03-26 um 14 16 47

vs

bildschirmfoto 2017-03-26 um 14 16 32

@codecov-io

codecov-io commented Mar 26, 2017 •

Copy link
Copy Markdown

Codecov Report

Merging #4082 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4082      +/-   ##
============================================
+ Coverage     54.24%   54.24%   +<.01%     
+ Complexity    21285    21278       -7     
============================================
  Files          1310     1310              
  Lines         81187    81196       +9     
  Branches       1284     1284              
============================================
+ Hits          44037    44044       +7     
- Misses        37150    37152       +2
Impacted Files Coverage Δ Complexity Δ
apps/files/lib/App.php 27.27% <0%> (-47.73%) 2% <0%> (ø)
lib/private/NavigationManager.php 53.03% <0%> (-33.54%) 39% <0%> (+13%)
core/js/js.js 62.17% <0%> (-0.15%) 0% <0%> (ø)
lib/private/Server.php 92.97% <0%> (-0.06%) 120% <0%> (ø)
core/templates/layout.user.php 0% <0%> (ø) 0% <0%> (ø) ⬇️
lib/private/TemplateLayout.php 0% <0%> (ø) 33% <0%> (-1%) ⬇️
settings/js/apps.js 26.71% <0%> (+0.12%) 0% <0%> (ø) ⬇️
lib/private/legacy/app.php 50% <0%> (+3.07%) 228% <0%> (-19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dd5d73...0322e7a. Read the comment docs.

@jancborchardt

Copy link
Copy Markdown
Member

it additionally also fixes other pop over menus, because they were also greyed out.

This was intended to show which of the states is active and it’s a regression that it’s gone. Fixed it with my commit :)
capture du 2017-03-27 11-17-26

@jancborchardt jancborchardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s do it! :)

@MorrisJobke

Copy link
Copy Markdown
Member Author

@skjnldsv
skjnldsv merged commit f88a578 into master Mar 28, 2017
@skjnldsv
skjnldsv deleted the fix-menu branch March 28, 2017 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug design Design, UI, UX, etc. high regression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants