@individual-it, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @rullzer and @blizzz to be potential reviewers.

I cannot find any tests for the upload-only page, are there any?

perhaps here? apps/files_sharing/tests/js/publicAppSpec.js at least there is an upload-specific part, small though.

@blizzz

perhaps here? apps/files_sharing/tests/js/publicAppSpec.js at least there is an upload-specific part, small though.

That does look to me like its for public upload generally not specific for upload-only folders. So this function might be pretty untested, at least the JS side of it

yes unfortunatly it is pretty untested...

So, let's go out without for now? Or are you eager do add tests @individual-it? :) :) :)

Or are you eager do add tests?

Generally speaking: Yes! Are you eager to pay me for that :-) ?

My business partner @phil-davis (from Australia) and me (from Germany), we both lived in Nepal for the past 6/8 years and have worked here for an big NGO, now we have moved on and are in the process of starting a Software Development Company in Nepal @JankariTech

Writing automated tests is exactly the service we are planing to offer. The idea is to teach young Nepali IT graduates to write good automated tests and to offer to write tests to companies that do not have enough testing for their projects.

If you are interested happy to keep on talking by Email ([email protected]) or Skype

Generally speaking: Yes! Are you eager to pay me for that :-) ?
Writing automated tests is exactly the service we are planing to offer.

Well, showing us and the rest of the world your test-writing-skills here would be the best possible advertisement for your new company 😉

Codecov Report

Merging #4212 into master will increase coverage by 0.01%.
The diff coverage is 89.28%.

@@             Coverage Diff              @@
##             master    #4212      +/-   ##
============================================
+ Coverage     54.07%   54.08%   +0.01%     
  Complexity    21589    21589              
============================================
  Files          1327     1328       +1     
  Lines         82303    82367      +64     
  Branches       1305     1311       +6     
============================================
+ Hits          44509    44552      +43     
- Misses        37794    37815      +21

@schiessle @nickvergessen @blizzz Please review :)