Repository navigation
Public capabilities API - #5567
Merged
Merged
Conversation
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
requested review from
LukasReschke,
MorrisJobke,
nickvergessen and
rullzer
June 30, 2017 09:22
|
|
||
| if ($c instanceof ICapability) { | ||
| $capabilities = array_replace_recursive($capabilities, $c->getCapabilities()); | ||
| if(!$public || ($public && $c instanceof IPublicCapability)) { |
Member
There was a problem hiding this comment.
remove ($public && it's not needed
Signed-off-by: Julius Härtl <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #5567 +/- ##
============================================
- Coverage 53.98% 53.98% -0.01%
- Complexity 22466 22469 +3
============================================
Files 1390 1390
Lines 85980 85984 +4
Branches 1329 1329
============================================
+ Hits 46418 46419 +1
- Misses 39562 39565 +3
|
Member
|
It should also be added to https://lukasreschke.github.io/OpenCloudMeshSpecification/ then ;) |
Signed-off-by: Morris Jobke <[email protected]>
rullzer
approved these changes
Jul 12, 2017
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows apps to expose capabilities to unauthenticated users as proposed in #4510.
Apps can make use of this by implementing IPublicCapability instead of ICapability.
The second commit will expose theming values to public to allow clients to obtain those values even before login.