Allows files/folders to be copied. by tcitworld · Pull Request #6014 · nextcloud/server

tcitworld · 2017-08-07T16:19:12Z

Adds a Copy action in the file action menu.
This also enables copy ~~and move~~ actions on selected files.

I know this is not how @jancborchardt designed it here, and that the files_clipboard app is being developed but hey, this works for me, so it might be worth a look. :)
Ref. #3206

Needs :

Tests
~~Copy action icon~~
Tests on federated shares, remote storage, ...
Tests for regressions on filepicker UI

The move feature has been moved at #6273

mention-bot · 2017-08-07T16:19:18Z

@tcitworld, thanks for your PR! By analyzing the history of the files in this pull request, we identified @noveens, @PVince81 and @butonic to be potential reviewers.

tcitworld · 2017-08-07T16:19:39Z

 			});
+			if (callback) {
+				callback();
+			}


MorrisJobke · 2017-08-08T12:46:56Z

cc @danxuliu

@tcitworld Could I ask you to split the "add copy" and the "move for selected files" into two PRs? Then we could work on them in parallel and one does not block the other feature.

tcitworld · 2017-08-08T12:51:04Z

Yup, will do that.

jancborchardt

Nice work! However I would really like an addition like that to only come in with the design as specified at #3206 (comment)

Could you adjust it to that? :)

codecov · 2017-08-27T13:28:49Z

Codecov Report

Merging #6014 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##             master   #6014      +/-   ##
===========================================
- Coverage     53.43%   53.4%   -0.03%     
  Complexity    22545   22545              
===========================================
  Files          1408    1408              
  Lines         87210   87260      +50     
  Branches       1328    1340      +12     
===========================================
+ Hits          46601   46604       +3     
- Misses        40609   40656      +47

Impacted Files	Coverage Δ	Complexity Δ
core/js/oc-dialogs.js	`0.43% <0%> (-0.03%)`	`0 <0> (ø)`
apps/files/templates/list.php	`0% <0%> (ø)`	`0 <0> (ø)`	⬇️
core/js/files/client.js	`82.86% <0%> (-4.64%)`	`0 <0> (ø)`
core/js/jquery.ocdialog.js	`1.53% <0%> (-0.04%)`	`0 <0> (ø)`
lib/private/Server.php	`84.37% <0%> (+0.12%)`	`123% <0%> (ø)`	⬇️
apps/files_trashbin/lib/Trashbin.php	`72.53% <0%> (+0.24%)`	`136% <0%> (ø)`	⬇️
lib/private/Files/Cache/Propagator.php	`96.2% <0%> (+1.26%)`	`16% <0%> (ø)`	⬇️

tcitworld · 2017-08-27T15:41:03Z

Looks like this @jancborchardt

jancborchardt · 2017-08-27T20:08:37Z

@tcitworld nice! :) Was just mentioning it in the design lightning talk today. ;) Is the menu also changed to say »Move or Copy«? (Will test the whole flow later)

jancborchardt · 2017-08-27T20:09:28Z

-				name: 'Move',
-				displayName: t('files', 'Move'),
+				name: 'CopyMove',
+				displayName: t('files', 'Copy or Move'),


Just a tiny one: First move, then copy. So »Move or copy« :) (with small _c_opy)

jancborchardt · 2017-08-27T20:09:52Z

+						<a href="" class="copy-move">
 							<span class="icon icon-external"></span>
-							<span><?php p($l->t('Copy'))?></span>
+							<span><?php p($l->t('Copy or Move'))?></span>


Same here, »Move or copy« :)

icewind1991

Looks good otherwise

icewind1991 · 2017-08-28T08:40:31Z

+			};
+
+			var copyCallback = function () {
+				console.log('copy callback');


leftover debug statement

icewind1991 · 2017-08-28T08:46:50Z

 					<span id="selectedActionsList" class="selectedActions">
+						<a href="" class="copy-move">
+							<span class="icon icon-external"></span>
+							<span><?php p($l->t('Copy or Move'))?></span>


Same thing here as @jancborchardt said

Changed move and copy

tcitworld · 2017-08-31T08:16:10Z

Rebased now that #6273 is merged.

icewind1991

works great 👍

jancborchardt · 2017-09-10T18:22:08Z

👍 from my side. What about the failing tests @tcitworld @MorrisJobke?

MorrisJobke · 2017-09-11T21:31:01Z

👍 from my side. What about the failing tests @tcitworld @MorrisJobke?

Those are timeouts, that are solved in current master/stable12 and this is simply from an older version of them. In the future they should not happen at all (or at least not that often anymore).

MorrisJobke · 2017-09-11T21:31:54Z

Tests
Tests on federated shares, remote storage, ...
Tests for regressions on filepicker UI

What about those pending items? @tcitworld Could you add at least some tests for this?

Signed-off-by: Thomas Citharel <[email protected]>

…older sizes Signed-off-by: Thomas Citharel <[email protected]>

Signed-off-by: Thomas Citharel <[email protected]>

tcitworld · 2017-09-15T16:17:51Z

I added tests and fixed a behaviour where failed copy actions were also counted as successful. Please review again.

jancborchardt · 2017-09-17T17:44:32Z

@tcitworld looks like the commits should be squashed into one? :) Also, there’s some Drone failures

danxuliu · 2017-09-18T03:13:00Z

there’s some Drone failures

The failure was in an acceptance test... that should not have failed (I have run the test in local and it worked fine). Restarting the build will hopefully make the failure to go away (although I will have to study the failure in detail anyway; I hope it does not appear too frequently in Drone until then :-S ).

agoat · 2017-09-18T12:55:16Z

Nice work @tcitworld. Thanks.

jancborchardt · 2017-09-19T06:59:56Z

Yup, great work @tcitworld :)

tcitworld added 2. developing Work in progress feature: files labels Aug 7, 2017

tcitworld commented Aug 7, 2017

View reviewed changes

Comment thread apps/files/js/filelist.js Outdated

});

if (callback) {

callback();

}

tcitworld Aug 7, 2017

Copy link
Copy Markdown

Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dirty.

tcitworld requested review from icewind1991 and rullzer August 7, 2017 16:25

jancborchardt previously requested changes Aug 12, 2017

View reviewed changes

rullzer added this to the Nextcloud 13 milestone Aug 25, 2017

tcitworld mentioned this pull request Aug 27, 2017

Move multiple files #6273

Merged

tcitworld force-pushed the add-copy-action branch from 8fb4750 to b6b9244 Compare August 27, 2017 13:28

jancborchardt reviewed Aug 27, 2017

View reviewed changes

icewind1991 previously requested changes Aug 28, 2017

View reviewed changes

tcitworld force-pushed the add-copy-action branch from 2684dc3 to 26a1120 Compare August 31, 2017 08:12

icewind1991 approved these changes Aug 31, 2017

View reviewed changes

jancborchardt approved these changes Sep 12, 2017

View reviewed changes

tcitworld added 3 commits September 15, 2017 16:53

Allow files to be copied through action menu & multiple files actions

246a5a5

Signed-off-by: Thomas Citharel <[email protected]>

[WIP] Added copy and move buttons

33f0601

Signed-off-by: Thomas Citharel <[email protected]>

typo

07c1137

Signed-off-by: Thomas Citharel <[email protected]>

tcitworld added 3 commits September 15, 2017 16:53

Change move copy order and debug leftover

5767659

Signed-off-by: Thomas Citharel <[email protected]>

Don't show success notifications for failed copy actions and update f…

98ee32b

…older sizes Signed-off-by: Thomas Citharel <[email protected]>

Add tests for FileList

8c576a8

Signed-off-by: Thomas Citharel <[email protected]>

tcitworld force-pushed the add-copy-action branch from 26a1120 to 8c576a8 Compare September 15, 2017 16:15

tcitworld added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 15, 2017

MorrisJobke approved these changes Sep 18, 2017

View reviewed changes

MorrisJobke merged commit f9dc6c4 into master Sep 18, 2017

MorrisJobke deleted the add-copy-action branch September 18, 2017 12:19

MorrisJobke mentioned this pull request Sep 18, 2017

Add option to copy/duplicate files #3206

Closed

jancborchardt mentioned this pull request Sep 22, 2017

Make file actions the same in all views nextcloud/android#580

Open

tflidd mentioned this pull request Nov 3, 2017

Bulk move files #7045

Closed

jancborchardt added the design Design, UI, UX, etc. label Nov 6, 2017

e-alfred mentioned this pull request Jan 25, 2018

support nc 13 felixrupp/owncloud-files_clipboard#32

Closed

JSoko mentioned this pull request Jan 31, 2018

Compatibility with Nextcloud 13 felixrupp/owncloud-files_clipboard#34

Closed

Cybso mentioned this pull request Feb 6, 2018

Split move and copy operations #8203

Merged

Conversation

tcitworld commented Aug 7, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mention-bot commented Aug 7, 2017

Uh oh!

tcitworld Aug 7, 2017

Choose a reason for hiding this comment

Uh oh!

MorrisJobke commented Aug 8, 2017

Uh oh!

tcitworld commented Aug 8, 2017

Uh oh!

jancborchardt left a comment

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Aug 27, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

tcitworld commented Aug 27, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jancborchardt commented Aug 27, 2017

Uh oh!

jancborchardt Aug 27, 2017

Choose a reason for hiding this comment

Uh oh!

jancborchardt Aug 27, 2017

Choose a reason for hiding this comment

Uh oh!

icewind1991 left a comment

Choose a reason for hiding this comment

Uh oh!

icewind1991 Aug 28, 2017

Choose a reason for hiding this comment

Uh oh!

icewind1991 Aug 28, 2017

Choose a reason for hiding this comment

Uh oh!

tcitworld commented Aug 31, 2017

Uh oh!

icewind1991 left a comment

Choose a reason for hiding this comment

Uh oh!

jancborchardt commented Sep 10, 2017

Uh oh!

MorrisJobke commented Sep 11, 2017

Uh oh!

MorrisJobke commented Sep 11, 2017

Uh oh!

tcitworld commented Sep 15, 2017

Uh oh!

jancborchardt commented Sep 17, 2017

Uh oh!

danxuliu commented Sep 18, 2017

Uh oh!

agoat commented Sep 18, 2017

Uh oh!

jancborchardt commented Sep 19, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

tcitworld commented Aug 7, 2017 •

edited

Loading

codecov Bot commented Aug 27, 2017 •

edited

Loading

tcitworld commented Aug 27, 2017 •

edited

Loading