Repository navigation
Fix hovering on all popover types - #6407
Merged
Merged
Conversation
skjnldsv
added
3. to review
skjnldsv
requested review from
ChristophWurst,
Espina2,
Henni,
MorrisJobke,
irgendwie,
jancborchardt,
juliusknorr and
nickvergessen
September 7, 2017 16:50
juliusknorr
approved these changes
Sep 7, 2017
Espina2
approved these changes
Sep 8, 2017
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
skjnldsv
force-pushed
the
fix-popover-hovering
branch
from
September 8, 2017 14:33
9be8f51 to
d50934f
Compare
MorrisJobke
added
4. to release
Codecov Report
@@ Coverage Diff @@
## master #6407 +/- ##
===========================================
+ Coverage 53.4% 53.4% +<.01%
Complexity 22515 22515
===========================================
Files 1407 1407
Lines 87086 87086
Branches 1329 1329
===========================================
+ Hits 46511 46512 +1
+ Misses 40575 40574 -1
|
Member
Author
|
Thx @MorrisJobke 😙 |
Member
Author
|
@MorrisJobke @nextcloud/designers |
Member
|
Cc @karlitschek I'm fine with this 👌 |
Member
|
backport makes sense |
Member
Author
|
Backport in #6427 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When hovering some popover who don't use the menuitem class (we're suppose to have dropped this requirement) the highlight effect do not work for two reasons:
This will need a backport I think.
.
@nextcloud/designers please review