Repository navigation
[stable12] Ask the schema whether the table and column exist - #6442
Merged
MorrisJobke merged 2 commits intoSep 11, 2017
Merged
Conversation
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
added
3. to review
nickvergessen
requested review from
Ivansss,
LukasReschke,
MorrisJobke and
fancycode
September 11, 2017 09:17
nickvergessen
commented
Sep 11, 2017
| // This is the equivalent of the new migration code that is used in 13+ | ||
| $filterExpression = '/^' . preg_quote($this->config->getSystemValue('dbtableprefix', 'oc_')) . '/'; | ||
| $this->db->getConfiguration()->setFilterSchemaAssetsExpression($filterExpression); | ||
| $schema = $this->db->getSchemaManager()->createSchema(); |
Member
Author
There was a problem hiding this comment.
This is the code which is mocked away in 13+ with migrations, that's why 1. it was not used like this before and 2. the diff is different compared to the 13 PR
MorrisJobke
deleted the
backport-6416-make-sure-sqlite-works-without-content
branch
September 11, 2017 21:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #6416