Codecov Report

Merging #6460 into master will increase coverage by <.01%.
The diff coverage is 95%.

@@             Coverage Diff              @@
##             master    #6460      +/-   ##
============================================
+ Coverage     50.72%   50.73%   +<.01%     
- Complexity    24478    24479       +1     
============================================
  Files          1581     1581              
  Lines         93578    93596      +18     
  Branches       1359     1359              
============================================
+ Hits          47471    47484      +13     
- Misses        46107    46112       +5

Tests are also fixed now. Please review @nextcloud/theming @nickvergessen

bump ... please review @nextcloud/theming

How can we test this? :)

@skjnldsv You need imagemagick enabled in your webserver setup. Then the endpoint http://localhost/index.php/apps/theming/favicon/core should return an ico file with different sizes.

@skjnldsv You need imagemagick enabled in your webserver setup. Then the endpoint http://localhost/index.php/apps/theming/favicon/core should return an ico file with different sizes.

#7100

@skjnldsv You need imagemagick enabled in your webserver setup. Then the endpoint http://localhost/index.php/apps/theming/favicon/core should return an ico file with different sizes.

I did, but I only get one picture. 32x32

@skjnldsv I think most browsers/image viewers will show only a single image. Opening in gimp should show up the different sizes as single layers.

Hum, I only have one layer. Header is set and working.

Can you change the color and try it again? I guess we need to trigger the regeneration when updating.

I like it and it works here, but somehow postgres fails hard:

Error while trying to create admin user: An exception occurred while executing 'SELECT min_value, increment_by FROM "oc_personal_settings_id_seq"':
21s
14

21s
15
SQLSTATE[42703]: Undefined column: 7 ERROR:  column "min_value" does not exist
21s
16
LINE 1: SELECT min_value, increment_by FROM "oc_personal_settings_id...
21s
17
               ^
21s
18
 -> 

@MorrisJobke Tests run fine locally. I rebased and pushed again. Let's see if that one still fails.

I like it and it works here, but somehow postgres fails hard:

@MorrisJobke Postgres 10 is still not supported: #5930