Repository navigation
add postgresql 10 compatibility to dbal - #7210
Merged
Merged
Conversation
icewind1991
force-pushed
the
pg10
branch
2 times, most recently
from
November 22, 2017 13:58
82e5cb7 to
9ca4bd0
Compare
Codecov Report
@@ Coverage Diff @@
## master #7210 +/- ##
============================================
+ Coverage 50.84% 50.87% +0.02%
+ Complexity 24548 24534 -14
============================================
Files 1585 1584 -1
Lines 93804 93770 -34
Branches 1354 1356 +2
============================================
+ Hits 47693 47703 +10
+ Misses 46111 46067 -44
|
rullzer
previously requested changes
Nov 22, 2017
rullzer
left a comment
rullzer
left a comment
Member
There was a problem hiding this comment.
Can you add a drone job for postgres10 so we actually know it works ;)
icewind1991
force-pushed
the
pg10
branch
2 times, most recently
from
November 22, 2017 16:29
f903043 to
ab2e268
Compare
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Member
Author
|
@rullzer done |
MorrisJobke
approved these changes
Nov 27, 2017
Member
|
Please update 3rdparty to contain current master. |
Signed-off-by: Lukas Reschke <[email protected]>
LukasReschke
left a comment
LukasReschke
left a comment
Member
There was a problem hiding this comment.
Code looks good. Updated the thirdparty ref. Let's see what CI says :)
nickvergessen
approved these changes
Nov 27, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update doctrine/dbal to include doctrine/dbal#2893 and doctrine/dbal#2916 to make it work with postgresql 10