Repository navigation
Make it possible to make external storages read only - #8564
Merged
Merged
Conversation
rullzer
added
enhancement
2. developing
rullzer
force-pushed
the
files_external_read_only
branch
from
March 8, 2018 18:54
19a5e0d to
ab14f66
Compare
Codecov Report
@@ Coverage Diff @@
## master #8564 +/- ##
===========================================
- Coverage 51.76% 51.37% -0.4%
+ Complexity 25558 25392 -166
===========================================
Files 1627 1541 -86
Lines 95939 87509 -8430
Branches 1393 0 -1393
===========================================
- Hits 49667 44954 -4713
+ Misses 46272 42555 -3717
|
rullzer
force-pushed
the
files_external_read_only
branch
2 times, most recently
from
March 8, 2018 21:22
ef13570 to
6ef2da3
Compare
rullzer
added
3. to review
| $l->t("Check for changes"); | ||
| $l->t("Never"); | ||
| $l->t("Once every direct access"); | ||
| $l->t('Read only'); |
Member
There was a problem hiding this comment.
???
Language extraction not working for something?
Member
Author
There was a problem hiding this comment.
To be honest I just extended this all. I didn't look into the dark magic of the files_external code yet.
rullzer
force-pushed
the
files_external_read_only
branch
from
April 26, 2018 10:08
6ef2da3 to
857f378
Compare
Signed-off-by: Roeland Jago Douma <[email protected]>
Signed-off-by: Roeland Jago Douma <[email protected]>
Signed-off-by: Roeland Jago Douma <[email protected]>
rullzer
force-pushed
the
files_external_read_only
branch
from
May 1, 2018 13:20
857f378 to
ea5393e
Compare
Member
Author
|
Rebased |
icewind1991
approved these changes
May 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repalces #8315
CC: @Cybso this was the way I suggested. It needs more work but I feel this is way more scaleable and mantainable ;)
Todo:
So it became a bit more.