Skip to content

Fixed breadcrumb menu flashing - #8574

Merged
MorrisJobke merged 1 commit into
masterfrom
breadcrumb-flash-fix
Mar 1, 2018
Merged

MorrisJobke merged 1 commit into
masterfrom
breadcrumb-flash-fix

Conversation

@skjnldsv

@skjnldsv skjnldsv commented Feb 28, 2018 •

Copy link
Copy Markdown
Member

Fixes #7159
@nextcloud/designers

Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv skjnldsv added bug design Design, UI, UX, etc. 3. to review Waiting for reviews papercut Annoying recurring UX issue with possibly simple fix. labels Feb 28, 2018
@skjnldsv skjnldsv added this to the Nextcloud 14 milestone Feb 28, 2018
@skjnldsv skjnldsv self-assigned this Feb 28, 2018
@skjnldsv
skjnldsv requested a review from danxuliu February 28, 2018 10:06

@danxuliu danxuliu left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works; code makes sense (menutoggle CSS class has to be set on the toggle element to prevent the menu from being hidden and then shown again for the same click) 👍

@MorrisJobke
MorrisJobke merged commit 6b4a2d0 into master Mar 1, 2018
@MorrisJobke
MorrisJobke deleted the breadcrumb-flash-fix branch March 1, 2018 08:39
@blizzz

blizzz commented Mar 2, 2018

Copy link
Copy Markdown
Member

thx @skjnldsv :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug design Design, UI, UX, etc. feature: files papercut Annoying recurring UX issue with possibly simple fix.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants