Repository navigation
Sorts filepicker files by modified date - #8820
Merged
Merged
Conversation
Signed-off-by: Sagorika Das <[email protected]>
Member
|
@icewind1991 @nextcloud/javascript need a code review here please :) |
jancborchardt
left a comment
jancborchardt
left a comment
Member
There was a problem hiding this comment.
It’s great! What about the second part of the issue:
Maybe even better, respect the sorting of the folders exactly as in the Files app.
Member
|
Oh .. sorry we missed that one somehow :/ Code looks good so far. Getting the ordering of the folder could be tricky, because AFAIK we don't store this yet. |
Member
|
@MorrisJobke ok, if that’s tricky let’s do @sagorika1996’s improvement here as a first step. :) |
MorrisJobke
approved these changes
Apr 11, 2018
skjnldsv
approved these changes
Apr 12, 2018
skjnldsv
left a comment
skjnldsv
left a comment
Member
There was a problem hiding this comment.
I restarted the tests, there was an acceptance fail on files, so I want to be sure :)
Great work otherwise!
Member
|
CI failures are unrelated. |
This was referenced Apr 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #645