Skip to content

Update master php testing versions - #122

Merged
come-nc merged 9 commits into
masterfrom
update-master-php-testing-versions
Apr 12, 2022
Merged

come-nc merged 9 commits into
masterfrom
update-master-php-testing-versions

Conversation

@nickvergessen

Copy link
Copy Markdown
Member

Signed-off-by: Joas Schilling [email protected]

@nickvergessen

Copy link
Copy Markdown
Member Author

Run ./vendor/phpunit/phpunit/phpunit -c ./tests/phpunit.xml
/home/runner/work/_temp/7daee967-9cf7-4fd5-abde-c7b457e5a402.sh: line 1: ./vendor/phpunit/phpunit/phpunit: No such file or directory
Error: Process completed with exit code 127.

@nickvergessen

Copy link
Copy Markdown
Member Author

Missing composer.lock update so it's not installed?

@come-nc

come-nc commented Apr 4, 2022

Copy link
Copy Markdown
Contributor

I’m lost, the use for the dependency seem all wrong, why is it use Office365\PHP\Client\Runtime\* instead of use Office365\Runtime\*? New version changed the namespace?

@come-nc

come-nc commented Apr 4, 2022

Copy link
Copy Markdown
Contributor

Ok it’s from 2.4.0: https://github.com/vgrem/phpSPO/releases/tag/v2.4.0

@blizzz You seem to have contributions upstream, could you look into bringing the code up to date with upstream api changes?

@blizzz

blizzz commented Apr 4, 2022

Copy link
Copy Markdown
Member

Ok it’s from 2.4.0: https://github.com/vgrem/phpSPO/releases/tag/v2.4.0

@blizzz You seem to have contributions upstream, could you look into bringing the code up to date with upstream api changes?

It's in #62 need to finish this off

@blizzz

This comment was marked as outdated.

nickvergessen and others added 6 commits April 11, 2022 21:55
@blizzz
blizzz force-pushed the update-master-php-testing-versions branch from e3cdd64 to 377d191 Compare April 11, 2022 19:57
@blizzz
blizzz force-pushed the update-master-php-testing-versions branch from 4a93635 to b43bd4b Compare April 11, 2022 20:04
blizzz added 2 commits April 11, 2022 23:12
Signed-off-by: Arthur Schiwon <[email protected]>
@blizzz
blizzz force-pushed the update-master-php-testing-versions branch from f861055 to e19a6ae Compare April 11, 2022 21:19
@blizzz

blizzz commented Apr 11, 2022

Copy link
Copy Markdown
Member

@come-nc i've added another flock of commits (upon a rebase). Seems like unit tests did not run properly before? a bit weird. Anyway, green now – wanna look over them?

@come-nc

come-nc commented Apr 12, 2022 •

Copy link
Copy Markdown
Contributor

@come-nc i've added another flock of commits (upon a rebase). Seems like unit tests did not run properly before? a bit weird. Anyway, green now – wanna look over them?

Would be better to use the phpunit workflows from nextcloud/.github but that can be done at a later point, merging.

@come-nc
come-nc merged commit 85a9172 into master Apr 12, 2022
@delete-merged-branch
delete-merged-branch Bot deleted the update-master-php-testing-versions branch April 12, 2022 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants