Repository navigation
feat: implement filtering by tags - #2427
Merged
Merged
Conversation
raimund-schluessler
force-pushed
the
feat/noid/filter-by-tags
branch
3 times, most recently
from
January 1, 2024 18:12
cbc313c to
d0ee7f3
Compare
Signed-off-by: Raimund Schlüßler <[email protected]>
raimund-schluessler
force-pushed
the
feat/noid/filter-by-tags
branch
from
January 1, 2024 19:28
d0ee7f3 to
2419041
Compare
raimund-schluessler
marked this pull request as ready for review
January 1, 2024 19:32
This was referenced Jan 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility to filter by tags. We now show a filter menu at the top right, similar to how it's done in the Deck app.
Requires nextcloud-libraries/nextcloud-vue#5014 and nextcloud-libraries/nextcloud-vue#5017 for better usability. Currently, the
NcSelectcomponent in the filter dropdown opens by default and is clipped by the menu itself. This will be improved with the two PRs tonextcloud/vue. However, as the feature already works, we will not wait for the PRs to be merged.