Repository navigation
Add text/asciidoc mimetype - #3535
Conversation
|
Hi @bjornfor, Thanks a lot! That seems like a useful addition. Code also looks good 馃槈 . I added a test for two mimetypes we already support here: #3540. I'd be curious to see if you can add a test with this. If you get stuck or miss some documentation please let me know so we can make this work more smoothly. |
|
Hi @max-nextcloud, thanks, I can probably make a copy of the plain text test, without fully understanding it 馃槃 |
This allows editing AsciiDoc files, as plain text. This change depends on nextcloud/server@582f07c ("Add text/asciidoc mimetype"). Signed-off-by: Bj酶rn Forsman <[email protected]>
7aed707 to
89ceaae
Compare
|
@max-nextcloud: I rebased and added a test, but I think So I guess I'd like to say |
Does |
|
The For plaintext documents the editor just contains <pre><code>
FILE CONTENT
</code></pre>So this is working as expected. |
There was a problem hiding this comment.
Hey @bjornfor
Thanks for adding the test. Congratulations for figuring it out without understanding it.
馃攽 achievement unlocked 馃槈
Does
cy.getContent().find('pre').should('contain', 'Hello world')work?
Yes - that should do the trick. As @susnux explained getContent only looks at the content of the editor.
Feel free to add the hello world check - test also seems okay for me as is because it tests that text is loading the file.
Your last commit seems to lack a signoff. Other than that i think this is ready to go.
The failing node test is because the js still needs to be build here by commenting with /compile. It's a mess and we're working on fixing it. I can take care of that once you signed off the second commit.
Signed-off-by: Bj酶rn Forsman <[email protected]>
89ceaae to
7ddfe07
Compare
|
@susnux @max-nextcloud: Thanks. I added |
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
|
CI failure is not related. |
|
@max-nextcloud: Thanks! |
馃摑 Summary
This allows editing AsciiDoc files, as plain text.
This change depends on
nextcloud/server@582f07c
("Add text/asciidoc mimetype").
Signed-off-by: Bj酶rn Forsman [email protected]
Disclaimer: this is a trivial change, but I haven't tested (I don't know how).It has a test now.I based this on
#394 (comment)
馃毀 TODO
馃弫 Checklist
npm run lint/npm run stylelint/composer run cs:check)